-
Notifications
You must be signed in to change notification settings - Fork 41
Add Provisioning YAML File #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 1120
Are you sure you want to change the base?
Add Provisioning YAML File #180
Conversation
Can one of the admins verify this patch? |
add to approvelist |
be10620
to
3f22d38
Compare
Signed-off-by: Isha Sahni <[email protected]>
3f22d38
to
c30a6c1
Compare
Hi @spinler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What object path is this going to be on? There's the 'namespace' fields where you can specify them in the yaml so it'll generate constants.
@@ -0,0 +1,30 @@ | |||
name: xyz.openbmc_project.Provisioning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think 'name' is a recognized field at this level?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I wonder if this should be under Network. The upstream maintainer would have final say anyway I guess.
accordingly. | ||
parameters: [] | ||
|
||
- name: CheckPeerBMCConnection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raviteja-b Is this the interface you were thinking RBMC manager would call? I don't think so, because the API I was thinking of checks if authentication is also good between the BMCs which means provisioning already has to have been completed on each.
description: > | ||
Starts the provisioning process and updates the ProvisioningState | ||
accordingly. | ||
parameters: [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can just leave off this field if there are no parameters
property to indicate whether the BMC is provisioned, and methods to initiate | ||
provisioning and check the peer BMC connection. | ||
properties: | ||
- name: ProvisioningState |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'State' sounds like it should be an enum. If it's just a bool, how just about something like 'Provisioned'?
doc referred : https://github.ibm.com/p11-fw-design/p11-fw-designs/blob/f729f6a52c0212e364e02fff8d1d003ebabd8e3e/designs/provisioning/README.md