Skip to content

Add Provisioning YAML File #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 1120
Choose a base branch
from

Conversation

ishasahni2000
Copy link

@jenkins-openbmc-ibm
Copy link

Can one of the admins verify this patch?

@rfrandse
Copy link
Collaborator

add to approvelist

@ishasahni2000 ishasahni2000 force-pushed the provisioingInterfaces branch 6 times, most recently from be10620 to 3f22d38 Compare July 24, 2025 10:02
Signed-off-by: Isha Sahni <[email protected]>
@raviteja-b raviteja-b requested a review from spinler August 22, 2025 05:15
@raviteja-b
Copy link
Contributor

raviteja-b commented Aug 22, 2025

Hi @spinler
can you please review and share your views on this provisioning interface, if you have any idea on getting this provisioning interface upstream using different naming. will push this interface upstream after we conclude interface in this PR.

Copy link
Contributor

@spinler spinler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What object path is this going to be on? There's the 'namespace' fields where you can specify them in the yaml so it'll generate constants.

@@ -0,0 +1,30 @@
name: xyz.openbmc_project.Provisioning
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think 'name' is a recognized field at this level?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I wonder if this should be under Network. The upstream maintainer would have final say anyway I guess.

accordingly.
parameters: []

- name: CheckPeerBMCConnection
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raviteja-b Is this the interface you were thinking RBMC manager would call? I don't think so, because the API I was thinking of checks if authentication is also good between the BMCs which means provisioning already has to have been completed on each.

description: >
Starts the provisioning process and updates the ProvisioningState
accordingly.
parameters: []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can just leave off this field if there are no parameters

property to indicate whether the BMC is provisioned, and methods to initiate
provisioning and check the peer BMC connection.
properties:
- name: ProvisioningState
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'State' sounds like it should be an enum. If it's just a bool, how just about something like 'Provisioned'?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants