fix(core): add additional checks in verifyUniqueWithinMutation for pruned mutations

[matthewmcneely]

Description

This PR adds additional checks in edgraph/server.go::verifyUniqueWithinMutation for mutations that may have been conditionally pruned in updateMutations (called just before).

Also a basic test verifies not only the prevention of the panic but also assures unpruned mutations were applied. Note this is an improvement upon #9449 in that additional range and inner loop predicate checks were required (@gooohgb).

Assigning to @shivaji-kharse as the original author of this function.

Checklist

• Code compiles correctly and linting passes locally
• For all code changes, an entry added to the CHANGELOG.md file describing and linking to
  this PR
• Tests added for new functionality, or regression tests for bug fixes added as applicable

[Copilot]

Pull Request Overview

This PR enhances mutation verification by skipping pruned entries, enriches error context in binary copying, and adds a regression test to prevent panics when unique predicates are conditionally pruned.

• Skip out-of-bounds or nil entries in verifyUniqueWithinMutation to handle pruned mutations.
• Include source and destination paths in the copyBinary error message.
• Add TestWithConditionallyPrunedMutations to verify no panic and correct UID assignments.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
edgraph/server.go	Added bounds checks and updated duplicate-value logic in verifyUniqueWithinMutation.
dgraphtest/image.go	Augmented copyBinary error wrap to include toPath and fromPath.
dgraph/cmd/alpha/run_test.go	Introduced a test to cover conditionally pruned mutations and ensure stability.

Comments suppressed due to low confidence (1)

edgraph/server.go:2173

• [nitpick] Consider using %q or %s verbs instead of %v when formatting strings to ensure proper quoting and improve readability, e.g., "could not insert duplicate value %q for predicate %q".

					pred1Value, pred1.Predicate)

[trunk-io]

     

View Full Report ↗︎ ⋅ Docs