-
Notifications
You must be signed in to change notification settings - Fork 2
feat: add rollup config file to include dependencies in bundle #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add rollup config file to include dependencies in bundle #22
Conversation
sww314
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to build the distribution locally and then test from the HUVR frontend. You will need to point at the local dist.
This suggests using npm link.
https://stackoverflow.com/questions/8088795/installing-a-local-module-using-npm
jsheffie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I threw an eye on this,
while I don't know exactly what is happening here
I know conceptually what is happening. ( makeing our evaluate tooling work/package properly with its deponent libs )
Throwing an approve on here, because nothing jumped out as crazy.
I did not try n run or build this.
|
@lucasrijllart that seems strange. |
|
@sww314 the error message doesn't even make sense to me, and I don't have any more information. I tried again and the error didn't appear. I'll keep this version of evaluate installed while working on other things and will be on the lookout for more errors like these |

Summary
Using rollup plugins, we now include the mathjs and formulajs dependencies into our evaluate.js distribution source code. This way, the new error that appeared after recent changes disappears and the library works again.
More explanation in demo
Changes:
_distcommand to use the new rollup.config.jsVisualize
Screenshare.-.2025-04-03.2_32_35.PM.mp4
Ran out of time in the demo but these are the calculations I wanted to show:

Next steps
These are my assumptions: