[SDK][Typescript] feat!: encryption module now works with binaries #2738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
vercel
bot
temporarily deployed
to
Preview – human-dashboard-frontend
vercel
bot
temporarily deployed
to
Preview – human-dashboard-frontend
vercel
bot
temporarily deployed
to
Preview – human-dashboard-frontend
Dzeranov
approved these changes
Nov 5, 2024
portuu3
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Encryption module now works with binaries
Summary of changes
signAndEncryptandsignmethods now accept not onlystring, but alsoUint8Array(orBuffer, which is subclass of it), so we can properly works with some small files. In case we need something relatively big (e.g. >10Mb) - we will probably need to start supporting streams. We can see how it goes with performance over timedecryptmethod now always returnsUint8Array, so consumer of this API must know what to expect and how to process decrypted valueHow test the changes
/example/encrypt.tsfile addedRelated issues
Part of the #2717