chore: use binary return from sdk

Author: dnechay

packages/apps/fortune/exchange-oracle/server/src/modules/job/job.service.ts

@@ -347,7 +347,8 @@ export class JobService {
           this.pgpConfigService.passphrase,
         );
 
-        manifest = JSON.parse(await encryption.decrypt(manifestEncrypted));
+        const decryptedData = await encryption.decrypt(manifestEncrypted);
+        manifest = JSON.parse(Buffer.from(decryptedData).toString());
       } catch {
         throw new Error(ErrorJob.ManifestDecryptionFailed);
       }

packages/apps/fortune/exchange-oracle/server/src/modules/storage/storage.service.ts

@@ -57,7 +57,8 @@ export class StorageService {
           this.pgpConfigService.passphrase,
         );
 
-        return JSON.parse(await encryption.decrypt(fileContent)) as ISolution[];
+        const decryptedData = await encryption.decrypt(fileContent);
+        return JSON.parse(Buffer.from(decryptedData).toString()) as ISolution[];
       }
 
       return typeof fileContent == 'string'

packages/apps/fortune/recording-oracle/src/modules/storage/storage.service.ts

@@ -53,7 +53,8 @@ export class StorageService {
             this.pgpConfigService.passphrase,
           );
 
-          return JSON.parse(await encryption.decrypt(fileContent));
+          const decryptedData = await encryption.decrypt(fileContent);
+          return JSON.parse(Buffer.from(decryptedData).toString());
         } catch {
           throw new Error('Unable to decrypt manifest');
         }

packages/apps/job-launcher/server/src/modules/job/job.service.spec.ts

@@ -2650,9 +2650,11 @@ describe('JobService', () => {
       expect(storageService.uploadFile).toHaveBeenCalled();
       expect(
         JSON.parse(
-          await encryption.decrypt(
-            (storageService.uploadFile as any).mock.calls[0][0],
-          ),
+          Buffer.from(
+            await encryption.decrypt(
+              (storageService.uploadFile as any).mock.calls[0][0],
+            ),
+          ).toString(),
         ),
       ).toEqual(fortuneManifestParams);
     });
@@ -2675,9 +2677,11 @@ describe('JobService', () => {
       expect(storageService.uploadFile).toHaveBeenCalled();
       expect(
         JSON.parse(
-          await encryption.decrypt(
-            (storageService.uploadFile as any).mock.calls[0][0],
-          ),
+          Buffer.from(
+            await encryption.decrypt(
+              (storageService.uploadFile as any).mock.calls[0][0],
+            ),
+          ).toString(),
         ),
       ).toEqual(fortuneManifestParams);
     });
@@ -2699,9 +2703,11 @@ describe('JobService', () => {
       expect(storageService.uploadFile).toHaveBeenCalled();
       expect(
         JSON.parse(
-          await encryption.decrypt(
-            (storageService.uploadFile as any).mock.calls[0][0],
-          ),
+          Buffer.from(
+            await encryption.decrypt(
+              (storageService.uploadFile as any).mock.calls[0][0],
+            ),
+          ).toString(),
         ),
       ).toEqual(fortuneManifestParams);
     });
@@ -2768,9 +2774,11 @@ describe('JobService', () => {
       expect(storageService.uploadFile).toHaveBeenCalled();
       expect(
         JSON.parse(
-          await encryption.decrypt(
-            (storageService.uploadFile as any).mock.calls[0][0],
-          ),
+          Buffer.from(
+            await encryption.decrypt(
+              (storageService.uploadFile as any).mock.calls[0][0],
+            ),
+          ).toString(),
         ),
       ).toEqual(manifest);
     });
@@ -2793,9 +2801,11 @@ describe('JobService', () => {
       expect(storageService.uploadFile).toHaveBeenCalled();
       expect(
         JSON.parse(
-          await encryption.decrypt(
-            (storageService.uploadFile as any).mock.calls[0][0],
-          ),
+          Buffer.from(
+            await encryption.decrypt(
+              (storageService.uploadFile as any).mock.calls[0][0],
+            ),
+          ).toString(),
         ),
       ).toEqual(manifest);
     });
@@ -2816,9 +2826,11 @@ describe('JobService', () => {
       expect(storageService.uploadFile).toHaveBeenCalled();
       expect(
         JSON.parse(
-          await encryption.decrypt(
-            (storageService.uploadFile as any).mock.calls[0][0],
-          ),
+          Buffer.from(
+            await encryption.decrypt(
+              (storageService.uploadFile as any).mock.calls[0][0],
+            ),
+          ).toString(),
         ),
       ).toEqual(manifest);
     });

packages/apps/job-launcher/server/src/modules/job/job.service.ts

@@ -1013,7 +1013,9 @@ export class JobService {
 
     let manifest = await this.storageService.download(jobEntity.manifestUrl);
     if (typeof manifest === 'string' && isPGPMessage(manifest)) {
-      manifest = await this.encryption.decrypt(manifest as any);
+      manifest = Buffer.from(
+        await this.encryption.decrypt(manifest),
+      ).toString();
     }
 
     if (isValidJSON(manifest)) {
@@ -1496,7 +1498,9 @@ export class JobService {
 
     let manifest;
     if (typeof manifestData === 'string' && isPGPMessage(manifestData)) {
-      manifestData = await this.encryption.decrypt(manifestData as any);
+      manifestData = Buffer.from(
+        await this.encryption.decrypt(manifestData),
+      ).toString();
     }
 
     if (isValidJSON(manifestData)) {

packages/apps/job-launcher/server/src/modules/storage/storage.service.ts

@@ -41,7 +41,8 @@ export class StorageService {
         typeof fileContent === 'string' &&
         EncryptionUtils.isEncrypted(fileContent)
       ) {
-        return await this.encryption.decrypt(fileContent);
+        const decryptedData = await this.encryption.decrypt(fileContent);
+        return Buffer.from(decryptedData).toString();
       } else {
         return fileContent;
       }

packages/apps/reputation-oracle/server/src/modules/storage/storage.service.ts

@@ -83,10 +83,12 @@ export class StorageService {
         this.pgpConfigService.privateKey!,
         this.pgpConfigService.passphrase,
       );
+      const decryptedData = await encryption.decrypt(fileContent);
+      const content = Buffer.from(decryptedData).toString();
       try {
-        return JSON.parse(await encryption.decrypt(fileContent));
+        return JSON.parse(content);
       } catch {
-        return await encryption.decrypt(fileContent);
+        return content;
       }
     } else {
       return fileContent;