Skip to content

Prevent changesets from updating vn-number dependency in docs package #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2025
Merged

Prevent changesets from updating vn-number dependency in docs package #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
082c99d
Initial plan
Copilot Nov 4, 2025
9020b7e
Configure changesets to skip updating vn-number version in docs
Copilot Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .changeset/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@
"access": "restricted",
"baseBranch": "main",
"updateInternalDependencies": "patch",
"ignore": ["docs"]
"ignore": []
}
2 changes: 1 addition & 1 deletion docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"next": "16.0.1",
"react": "19.2.0",
"react-dom": "19.2.0",
"vn-number": "2.0.1"
"vn-number": "2.0.0"
Copy link

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downgrading vn-number from 2.0.1 to 2.0.0 may reintroduce bugs or lose features that were fixed in 2.0.1. If the docs workspace is being removed from the monorepo, it should reference the published version. Verify that version 2.0.0 is the correct dependency, as the root package.json shows the current version is 2.0.1.

Suggested change
"vn-number": "2.0.0"
"vn-number": "2.0.1"

Copilot uses AI. Check for mistakes.
},
"devDependencies": {
"@biomejs/biome": "2.3.2",
Expand Down
3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,7 @@
"vitest": "3.2.4"
},
"workspaces": [
".",
"docs"
"."
],
Comment on lines 48 to 50
Copy link

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workspaces configuration is inconsistent with pnpm-workspace.yaml, which still includes docs as a workspace package. This mismatch can cause unexpected behavior. Either remove the workspaces field entirely from package.json (since pnpm-workspace.yaml takes precedence) or ensure both configurations are aligned.

Copilot uses AI. Check for mistakes.
"files": [
"dist"
Expand Down