Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 4, 2025

Changesets was automatically updating the vn-number dependency version in docs/package.json during releases (see PR #57). The docs project should use the published npm version independently.

Changes

Decoupled changesets from docs package:

  • Removed docs from package.json workspaces array
  • Kept docs in pnpm-workspace.yaml for dependency management
  • Removed docs from .changeset/config.json ignore list (no longer needed)
  • Reset docs/package.json vn-number dependency to 2.0.0 (latest published)

Behavior

Before:

// package.json
"workspaces": [".", "docs"]

// When running changeset version:
// ❌ docs/package.json: "vn-number": "2.0.0" → "2.0.1"

After:

// package.json  
"workspaces": ["."]

// When running changeset version:
// ✅ docs/package.json: "vn-number": "2.0.0" (unchanged)

Changesets uses package.json workspaces, pnpm uses pnpm-workspace.yaml. Separating them allows pnpm to manage docs dependencies while changesets ignores it.

Original prompt

@copilot there is a problem with changesets that it will update the vn-number package inside docs's package.json
I don't want it, that project use separated version of the package.
Update configurations of changesets to skip update the version of vn-number inside docs folder.

Reference: #57


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@eddad05). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##             main       #58   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         6           
  Lines           ?       245           
  Branches        ?        82           
========================================
  Hits            ?       245           
  Misses          ?         0           
  Partials        ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 4, 2025

Copilot AI changed the title [WIP] Update changesets to skip vn-number version in docs Prevent changesets from updating vn-number dependency in docs package Nov 4, 2025
Copilot finished work on behalf of hckhanh November 4, 2025 08:49
Copilot AI requested a review from hckhanh November 4, 2025 08:49
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 4, 2025

CodSpeed Performance Report

Merging #58 will not alter performance

Comparing copilot/update-changesets-configuration (9020b7e) with main (e9b3f15)1

Summary

✅ 64 untouched

Footnotes

  1. No successful run was found on main (eddad05) during the generation of this report, so e9b3f15 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@hckhanh hckhanh marked this pull request as ready for review November 4, 2025 08:54
Copilot AI review requested due to automatic review settings November 4, 2025 08:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restructures the workspace configuration to remove the docs subdirectory from internal management. The changes align the Changesets configuration with the package management setup.

  • Removes docs from pnpm workspaces configuration
  • Updates docs/package.json to use version 2.0.0 of vn-number (downgrade from 2.0.1)
  • Removes the docs package from Changesets ignore list

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
package.json Removes docs from the workspaces array
docs/package.json Downgrades vn-number dependency from 2.0.1 to 2.0.0
.changeset/config.json Removes docs from the Changesets ignore list

Comment on lines 48 to 50
"workspaces": [
".",
"docs"
"."
],
Copy link

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workspaces configuration is inconsistent with pnpm-workspace.yaml, which still includes docs as a workspace package. This mismatch can cause unexpected behavior. Either remove the workspaces field entirely from package.json (since pnpm-workspace.yaml takes precedence) or ensure both configurations are aligned.

Copilot uses AI. Check for mistakes.
"react": "19.2.0",
"react-dom": "19.2.0",
"vn-number": "2.0.1"
"vn-number": "2.0.0"
Copy link

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downgrading vn-number from 2.0.1 to 2.0.0 may reintroduce bugs or lose features that were fixed in 2.0.1. If the docs workspace is being removed from the monorepo, it should reference the published version. Verify that version 2.0.0 is the correct dependency, as the root package.json shows the current version is 2.0.1.

Suggested change
"vn-number": "2.0.0"
"vn-number": "2.0.1"

Copilot uses AI. Check for mistakes.
@hckhanh hckhanh merged commit a8bffa5 into main Nov 4, 2025
18 checks passed
@hckhanh hckhanh deleted the copilot/update-changesets-configuration branch November 4, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants