-
Notifications
You must be signed in to change notification settings - Fork 1
Prevent changesets from updating vn-number dependency in docs package #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 6
Lines ? 245
Branches ? 82
========================================
Hits ? 245
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: hckhanh <[email protected]>
|
CodSpeed Performance ReportMerging #58 will not alter performanceComparing Summary
Footnotes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR restructures the workspace configuration to remove the docs subdirectory from internal management. The changes align the Changesets configuration with the package management setup.
- Removes
docsfrom pnpm workspaces configuration - Updates
docs/package.jsonto use version2.0.0ofvn-number(downgrade from2.0.1) - Removes the
docspackage from Changesets ignore list
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Removes docs from the workspaces array |
| docs/package.json | Downgrades vn-number dependency from 2.0.1 to 2.0.0 |
| .changeset/config.json | Removes docs from the Changesets ignore list |
| "workspaces": [ | ||
| ".", | ||
| "docs" | ||
| "." | ||
| ], |
Copilot
AI
Nov 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workspaces configuration is inconsistent with pnpm-workspace.yaml, which still includes docs as a workspace package. This mismatch can cause unexpected behavior. Either remove the workspaces field entirely from package.json (since pnpm-workspace.yaml takes precedence) or ensure both configurations are aligned.
| "react": "19.2.0", | ||
| "react-dom": "19.2.0", | ||
| "vn-number": "2.0.1" | ||
| "vn-number": "2.0.0" |
Copilot
AI
Nov 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Downgrading vn-number from 2.0.1 to 2.0.0 may reintroduce bugs or lose features that were fixed in 2.0.1. If the docs workspace is being removed from the monorepo, it should reference the published version. Verify that version 2.0.0 is the correct dependency, as the root package.json shows the current version is 2.0.1.
| "vn-number": "2.0.0" | |
| "vn-number": "2.0.1" |



Changesets was automatically updating the
vn-numberdependency version indocs/package.jsonduring releases (see PR #57). The docs project should use the published npm version independently.Changes
Decoupled changesets from docs package:
docsfrompackage.jsonworkspaces arraydocsinpnpm-workspace.yamlfor dependency managementdocsfrom.changeset/config.jsonignore list (no longer needed)docs/package.jsonvn-number dependency to2.0.0(latest published)Behavior
Before:
After:
Changesets uses
package.jsonworkspaces, pnpm usespnpm-workspace.yaml. Separating them allows pnpm to manage docs dependencies while changesets ignores it.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.