Skip to content

Warn don't error on expired test #14992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jakeii wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −48
Open

Warn don't error on expired test #14992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a02237
warn don't error on expired test
Jakeii Dec 10, 2025
87e5cf1
delete unnecessary test
Jakeii Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 0 additions & 46 deletions ab-testing/config/scripts/validation/validExpiration.test.ts
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions ab-testing/config/scripts/validation/validExpiration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ export function allExpirationsValid(tests: ABTest[]): boolean {
const now = new Date();

if (expires < now) {
throw new Error(
console.warn(
`${
test.name
} has an expiration date in the past: ${expires.toISOString()}, has it expired? If it doesn't belong to you or your team, you can set the status to OFF for now.`,
} has an expiration date in the past: ${expires.toISOString()}, has it expired?`,
);
}
});
Expand Down
Loading