Warn don't error on expired test #14992
Open
+2
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jakeii
added
run_chromatic
github-actions
bot
removed
the
run_chromatic
cemms1
reviewed
Dec 10, 2025
Contributor
cemms1
left a comment
cemms1
left a comment
There was a problem hiding this comment.
Maybe we could still error but but allow the workflow to continue past the error? https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#jobsjob_idstepscontinue-on-error
Member
Author
I think we'd still want to error if other test checks fail |
on-ye
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Don't error on expired tests in CI.
Why?
Although it's not a required check at the moment, it's still disconcerting to see.
Expired tests are not served to users so we can let them slide.
Something like an email to the owners would be more appropriate.