Skip to content

chore(gitignore): exclude java code packages from global python env patterns #13003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
meltsufin wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

chore(gitignore): exclude java code packages from global python env patterns #13003

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,13 @@ ENV/
env.bak/
venv.bak/

# Protect Java package folders from global Python virtualenv env/ and ENV/ blanket collisions
!**/src/main/java/**/env/
!**/src/test/java/**/env/
!**/src/main/proto/**/env/
!**/src/test/proto/**/env/
!**/src/main/java/**/ENV/
!**/src/test/java/**/ENV/
Comment on lines +44 to +49
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The current patterns are repetitive and inconsistent (for example, ENV/ is excluded for java but not for proto). Since it is highly improbable for a Python virtual environment to be located within a source directory, these can be simplified to a more maintainable form that covers all source types (Java, Proto, etc.) and both main/test sets consistently.

!**/src/**/env/
!**/src/**/ENV/

Copy link
Copy Markdown
Contributor

@blakeli0 blakeli0 May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this valid?


# Unit test / coverage reports
.coverage
Expand Down
Loading