chore(gitignore): exclude java code packages from global python env patterns#13003
Open
chore(gitignore): exclude java code packages from global python env patterns#13003
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the .gitignore file to prevent Java and Proto source directories named env/ or ENV/ from being ignored by global Python virtual environment rules. The reviewer suggested simplifying these patterns to a more maintainable and consistent format that covers all source directories under src/.
Comment on lines
+44
to
+49
| !**/src/main/java/**/env/ | ||
| !**/src/test/java/**/env/ | ||
| !**/src/main/proto/**/env/ | ||
| !**/src/test/proto/**/env/ | ||
| !**/src/main/java/**/ENV/ | ||
| !**/src/test/java/**/ENV/ |
Contributor
There was a problem hiding this comment.
The current patterns are repetitive and inconsistent (for example, ENV/ is excluded for java but not for proto). Since it is highly improbable for a Python virtual environment to be located within a source directory, these can be simplified to a more maintainable form that covers all source types (Java, Proto, etc.) and both main/test sets consistently.
!**/src/**/env/
!**/src/**/ENV/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be needed for java-bigtable.
Example:
java-bigtable/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/test_helpers/env/PrefixGenerator.java