Skip to content

chore: add permanent and conditional file exclusions#13000

Merged
lqiu96 merged 3 commits intomainfrom
feat/gemini-exclusions
May 5, 2026
Merged

chore: add permanent and conditional file exclusions#13000
lqiu96 merged 3 commits intomainfrom
feat/gemini-exclusions

Conversation

@blakeli0
Copy link
Copy Markdown
Contributor

@blakeli0 blakeli0 commented May 5, 2026

This PR adds permanent exclusions for legacy showcases and conditional exclusions for the test/ folder to GEMINI.md to prevent context window bloat in agentic workflows.

@blakeli0 blakeli0 requested a review from a team as a code owner May 5, 2026 00:58
@blakeli0 blakeli0 changed the title docs(gemini): add permanent and conditional file exclusions chore: add permanent and conditional file exclusions May 5, 2026
@blakeli0 blakeli0 requested a review from lqiu96 May 5, 2026 00:59
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the module exclusion list in .kokoro/common.sh and introduces a new section in sdk-platform-java/GEMINI.md regarding file exclusion and loading constraints to optimize context window usage. Feedback was provided regarding an inconsistent path change in the shell script that could lead to CI failures.

I am having trouble creating individual review comments. Click here to see my feedback.

.kokoro/common.sh (30)

high

The removal of the sdk-platform-java/ prefix for java-showcase is inconsistent with the versioned showcase entries on lines 31 and 32. If the module is still located within the sdk-platform-java directory, this change will break the CI exclusion logic for this module. Please verify if this was an accidental edit.

  'sdk-platform-java/java-showcase'
References
  1. When a module's path is updated, do not assume that related or versioned directories have also moved; their paths should be verified independently.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 5, 2026

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 5, 2026

Copy link
Copy Markdown
Member

@lqiu96 lqiu96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM let's try it

@lqiu96 lqiu96 merged commit 1c738a9 into main May 5, 2026
137 of 138 checks passed
@lqiu96 lqiu96 deleted the feat/gemini-exclusions branch May 5, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants