Skip to content

fix: add fallback to camera matrices when depth is not enabled #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JFGVL1187 merged 2 commits into from
Feb 17, 2026
Merged

fix: add fallback to camera matrices when depth is not enabled #167

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
765c78f
fix: add fallback to camera matrices when depth is not enabled
JFGVL1187 Feb 16, 2026
f7d9b93
Merge branch 'main' into pr-1-fix-camera-matrices
JFGVL1187 Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions demos/ballpit/BallShooter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,12 +132,21 @@ export class BallShooter extends xb.Script {
const position = sphere.position.copy(body.translation());
// If the ball falls behind the depth then adjust the spawnTime to begin
// expiring the ball.

// Use depth matrices if depth is enabled, otherwise fall back to camera matrices
const viewMatrix = xb.depth?.enabled
? xb.depth.depthViewMatrices[0]
: xb.core.camera.matrixWorldInverse;
const projectionMatrix = xb.depth?.enabled
? xb.depth.depthProjectionMatrices[0]
: xb.core.camera.projectionMatrix;

const viewSpacePosition = this.viewSpacePosition
.copy(position)
.applyMatrix4(xb.depth.depthViewMatrices[0]);
.applyMatrix4(viewMatrix);
const clipSpacePosition = this.clipSpacePosition
.copy(viewSpacePosition)
.applyMatrix4(xb.depth.depthProjectionMatrices[0]);
.applyMatrix4(projectionMatrix);
const ballIsInView =
-1.0 <= clipSpacePosition.x &&
clipSpacePosition.x <= 1.0 &&
Expand Down