Skip to content

fix: add fallback to camera matrices when depth is not enabled#167

Merged
JFGVL1187 merged 2 commits intogoogle:mainfrom
JFGVL1187:pr-1-fix-camera-matrices
Feb 17, 2026
Merged

fix: add fallback to camera matrices when depth is not enabled#167
JFGVL1187 merged 2 commits intogoogle:mainfrom
JFGVL1187:pr-1-fix-camera-matrices

Conversation

@JFGVL1187
Copy link
Collaborator

No description provided.

@JFGVL1187 JFGVL1187 requested a review from dli7319 February 17, 2026 08:01
@JFGVL1187 JFGVL1187 force-pushed the pr-1-fix-camera-matrices branch from e4d796a to 765c78f Compare February 17, 2026 08:05
Copy link
Collaborator

@ruofeidu ruofeidu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Adam!

also consider future coverage of phone camera

@dli7319
Copy link
Collaborator

dli7319 commented Feb 17, 2026

IMO, if we're using scene mesh, we shouldn't need to delete balls which fall out of view. The scene mesh should persist even as we turn our heads and the balls should continue moving even as they're out of view.

The reason for doing this with depth was that the depth mesh disappears in that region so when you turn and look back, the balls are free falling to y=-infinity.

@JFGVL1187
Copy link
Collaborator Author

IMO, if we're using scene mesh, we shouldn't need to delete balls which fall out of view. The scene mesh should persist even as we turn our heads and the balls should continue moving even as they're out of view.

The reason for doing this with depth was that the depth mesh disappears in that region so when you turn and look back, the balls are free falling to y=-infinity.

Sure David, It has been implemented in #144. The Mesh detector is currently doing periodic cleaning which means the submeshes that are not in the view for more than n seconds will be periodically checked and removed. So it means user can decide how long he/she wants the balls to persist in the scene. I also made a recording. Feel free to check it in the weekly notes update doc.

@dli7319
Copy link
Collaborator

dli7319 commented Feb 17, 2026

Oh I saw your recording. Awesome.
There's already a if (ballIsInView && xb.depth.enabled) so this is just to make it not crash I assume. Feel free to submit it.

@JFGVL1187 JFGVL1187 merged commit ecaa619 into google:main Feb 17, 2026
4 checks passed
@JFGVL1187 JFGVL1187 deleted the pr-1-fix-camera-matrices branch February 17, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments