fix: add fallback to camera matrices when depth is not enabled#167
fix: add fallback to camera matrices when depth is not enabled#167JFGVL1187 merged 2 commits intogoogle:mainfrom
Conversation
e4d796a to
765c78f
Compare
ruofeidu
left a comment
There was a problem hiding this comment.
Thank you Adam!
also consider future coverage of phone camera
|
IMO, if we're using scene mesh, we shouldn't need to delete balls which fall out of view. The scene mesh should persist even as we turn our heads and the balls should continue moving even as they're out of view. The reason for doing this with depth was that the depth mesh disappears in that region so when you turn and look back, the balls are free falling to y=-infinity. |
Sure David, It has been implemented in #144. The Mesh detector is currently doing periodic cleaning which means the submeshes that are not in the view for more than n seconds will be periodically checked and removed. So it means user can decide how long he/she wants the balls to persist in the scene. I also made a recording. Feel free to check it in the weekly notes update doc. |
|
Oh I saw your recording. Awesome. |
No description provided.