Skip to content

Fix type definition mismatch for emscripten bindings of FontMgr.matchFamilyStyle #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix type definition mismatch for emscripten bindings of FontMgr.matchFamilyStyle #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3105699
Fix type definition mismatch for emscripten bindings
pushpagarwal Jul 18, 2025
e1ea6af
Adding my name to AUTHORS file.
pushpagarwal Jul 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ Opera Software ASA <*@opera.com>
Pavel Krajcevski <[email protected]>
Petar Kirov <[email protected]>
Ping Wang <[email protected]>
Pushp Parag Agarwal <[email protected]>
Raul Tambre <[email protected]>
Roman Petrenko <[email protected]>
Safa Sofuoglu <[email protected]>
Expand Down
2 changes: 1 addition & 1 deletion modules/canvaskit/npm_build/types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2095,7 +2095,7 @@ export interface FontMgr extends EmbindObject<"FontMgr"> {
/**
* Find the closest matching typeface to the specified familyName and style.
*/
matchFamilyStyle(name: string, style: FontStyle): Typeface;
matchFamilyStyle(name: string, style: {width?: number, weight?: number, slant?: number}): Typeface;
}

/**
Expand Down