Skip to content

Conversation

pushpagarwal
Copy link

The current type definitions don't match the actual implementation where value objects and emscripten::val types are handled differently by the binding layer. This causes wrong match for typescript client using FontStyle type.

Updated type declarations to correctly reflect the emscripten binding behavior and ensure client written in ts works correctly.

The current type definitions don't match the actual implementation
where value objects and emscripten::val types are handled differently
by the binding layer. This causes wrong match for typescript client using FontStyle type.

Updated type declarations to correctly reflect the emscripten binding
behavior and ensure client written in ts works correctly.
Copy link

google-cla bot commented Jul 18, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pushpagarwal
Copy link
Author

JSFiddle showing Problem: https://jsfiddle.net/vxqornfp/

@pushpagarwal pushpagarwal marked this pull request as ready for review July 18, 2025 03:55
@pushpagarwal pushpagarwal changed the title Fix type definition mismatch for emscripten bindings Fix type definition mismatch for emscripten bindings of FontMgr.matchFamilyStyle Jul 18, 2025
@skia-codereview-bot
Copy link

This PR (HEAD: 3105699) has been imported to Gerrit for code review.

Please visit review.skia.org/1022517 to see it. Please CC yourself to the Gerrit change.

Note:

  • Skia uses only Gerrit for reviews and submitting code (doc).
  • All comments are handled within Gerrit. Any comments on the GitHub PR will be ignored.
  • The PR author can continue to upload commits to the branch used by the PR in order to address feedback from Gerrit.
  • Once the code is ready to be merged, a maintainer will submit the change on Gerrit and skia-codereview-bot will close this PR.
  • Similarly, if a change is abandoned on Gerrit, the corresponding PR will be closed with a note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants