Texture type validation fixes. - #120902
Merged
Repiteo merged 1 commit intoJul 3, 2026
Merged
Conversation
blueskythlikesclouds
force-pushed
the
texture-type-validation-fixes
branch
from
July 3, 2026 16:50
7c52851 to
04e0f78
Compare
clayjohn
requested changes
Jul 3, 2026
clayjohn
left a comment
Member
There was a problem hiding this comment.
Looks mostly good, just a small suggested change
blueskythlikesclouds
force-pushed
the
texture-type-validation-fixes
branch
from
July 3, 2026 17:35
04e0f78 to
70daaad
Compare
clayjohn
approved these changes
Jul 3, 2026
Contributor
|
Thanks! |
BendyLand
pushed a commit
to BendyLand/voltaire
that referenced
this pull request
Aug 2, 2026
…re-type-validation-fixes Texture type validation fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem(s) does this PR solve?
Follow-up to #120876 to solve texture type checks in half/quarter resolution sky textures alongside other tweaks.
Additional information
get_default_shader_rdto cache the results. Profiling showed this function sometimes taking up to 0.11~ ms, which comes from the shader version mutex.UniformSetFormatnow accounts for texture type/format, which can catch mismatches at draw time. This caught depth prepass creating uniform sets withtexture2Dinstead oftexture2DArrayfor multiview rendering. This was caused by_setup_render_pass_uniform_setchecking for multiview throughp_render_data, which isnullptrfor depth prepass.