refactor: Replace string cache keys with type-safe primary key methods #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the string-based cache key system with type-specific methods that accept primary key components directly, improving type safety and code clarity. **Removed:** - String cache key parsing logic (_parse_cache_key, _get_table_name) - Generic get/set/delete methods that accepted string keys - list_keys() method - cache_keys.py file with key generation functions - Cache key format constants **Added type-specific methods:** - PR Review: get_pr_review(), set_pr_review(), delete_pr_review() - PR Metadata: get_pr_metadata(), set_pr_metadata(), delete_pr_metadata() - PR Index: get_pr_index(), set_pr_index(), delete_pr_index() **Benefits:** - Type-safe API with explicit parameters - No string parsing overhead - Better IDE autocomplete and type checking - Simpler, more maintainable code (~200 lines removed) - Compiler-checked changes to primary keys All tests passing (60/60), ruff and mypy checks passed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor the SQLite cache system to eliminate string-based cache keys and replace them with type-specific methods that accept primary key components directly.
Changes
Removed string-based cache key system:
cache_keys.py- no longer needed_parse_cache_key()method that parsed string keys_get_table_name()method for key-to-table mappingget(key),set(key, ...),delete(key)methodslist_keys()methodAdded type-specific methods to SQLiteCache:
PR Review cache:
get_pr_review(owner, repo, pull_number)→ Returns cached review dataset_pr_review(owner, repo, pull_number, data, ...)→ Stores review datadelete_pr_review(owner, repo, pull_number)→ Deletes review entryPR Metadata cache:
get_pr_metadata(owner, repo, pr_number)→ Returns cached PR metadataset_pr_metadata(owner, repo, pr_number, data, ...)→ Stores PR metadatadelete_pr_metadata(owner, repo, pr_number)→ Deletes PR metadataPR Index cache:
get_pr_index(owner, repo)→ Returns cached PR indexset_pr_index(owner, repo, data, ...)→ Stores PR indexdelete_pr_index(owner, repo)→ Deletes PR indexUpdated CacheManager:
Benefits
✅ Type-safe API - Explicit parameters with proper types instead of string keys
✅ No parsing overhead - Direct parameter usage, no string splitting/validation
✅ Clearer method signatures - Self-documenting what each method does
✅ Better IDE support - Autocomplete and type checking work perfectly
✅ Simpler code - Removed ~200 lines of key parsing logic
✅ More maintainable - Changes to primary keys are compiler-checked
Test Plan
🤖 Generated with Claude Code