[WIP] Pulsar client for ARC #401
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be the general strategy for collecting input and output files for ARC, DIRAC, AWS batch etc.
Change base image from `conda/miniconda3` (based off Debian Stretch) to `python:3.12-bookworm`. Miniconda is not required in the base image. Add the Galaxy Depot repository, which provides SLURM DRMAA packages for Debian Buster and newer releases. Do not install the package `apt-transport-https`, it is now a dummy package, see https://packages.debian.org/en/bookworm/apt-transport-https. Install the package `slurm` instead of `slurm-llnl`. Newer versions of the `munge` package include the binary `/usr/sbin/mungekey` instead of `/usr/sbin/create-munge-key`. Nevertheless, the key seems to be created automatically when installing the package, as running `mungekey` yields 'mungekey: Error: Failed to create "/etc/munge/munge.key": File exists'.
Build wheel automatically when building the Docker image. Exclude the source code from the output image through a multistage build.
…oexecutionLaunchMixin` to `BaseRemoteConfiguredJobClient`
Implement a Pulsar client that runs jobs on computing infrastructure using the Advanced Resource Connector (ARC) middleware.
4 tasks
jmchilton
reviewed
Jul 3, 2025
pulsar/client/client.py
Outdated
| {pulsar_manifest_command.command} {" ".join(pulsar_manifest_command.args)} | ||
|
|
||
| cat job_directory/{output_manifest_path} | jq -r '.[] | "\(.from_path | sub("^{job_directory}/"; "job_directory/")) \(.url | capture("^(?<protocolurlhostport>[^:]+://[^/]+)(?<fileandmetadataoptions>/.*)") | "\(.protocolurlhostport);overwrite=yes\(.fileandmetadataoptions)" )"' > output.files | ||
| sed -i 's|https://galaxy-3923.local|http://b3bb955b30f267.lhr.life|g' output.files |
There was a problem hiding this comment.
Thanks for spotting it. That whole commit should be dropped, but arguably that line should never have made it there :).
jmchilton
reviewed
Jul 3, 2025
jmchilton
reviewed
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a Pulsar client that runs jobs on computing infrastructure using the Advanced Resource Connector (ARC) middleware.
Requires #399.