Skip to content

Strengthen sortBy/maxBy/minBy tests with two distinct projections #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gdziadkiewicz merged 2 commits into from
Mar 14, 2026
Merged

Strengthen sortBy/maxBy/minBy tests with two distinct projections #248

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d28c191
Initial plan
Copilot Mar 14, 2026
9d2fcde
Use two different projections in sortBy/maxBy/minBy tests
Copilot Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 26 additions & 5 deletions tests/FSharpx.Collections.Tests/NonEmptyListTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,11 +340,20 @@ module NonEmptyListTests =

testPropertyWithConfig
config10k
"sortBy produces sorted output"
"sortBy with identity projection produces ascending sorted output"
(Prop.forAll(neListOfInt())
<| fun nel ->
let sorted = NonEmptyList.sortBy id nel |> NonEmptyList.toList
let expected = nel |> NonEmptyList.toList |> List.sort
let expected = nel |> NonEmptyList.toList |> List.sortBy id
sorted = expected)

testPropertyWithConfig
config10k
"sortBy with negation projection produces descending sorted output"
(Prop.forAll(neListOfInt())
<| fun nel ->
let sorted = NonEmptyList.sortBy (fun x -> -x) nel |> NonEmptyList.toList
let expected = nel |> NonEmptyList.toList |> List.sortBy (fun x -> -x)
sorted = expected)

testPropertyWithConfig
Expand All @@ -358,12 +367,24 @@ module NonEmptyListTests =

testPropertyWithConfig
config10k
"maxBy returns maximum element"
"maxBy with identity projection returns maximum element"
(Prop.forAll(neListOfInt())
<| fun nel -> NonEmptyList.maxBy id nel = (nel |> NonEmptyList.toList |> List.max))

testPropertyWithConfig
config10k
"minBy returns minimum element"
"maxBy with negation projection returns minimum element"
(Prop.forAll(neListOfInt())
<| fun nel -> NonEmptyList.maxBy (fun x -> -x) nel = (nel |> NonEmptyList.toList |> List.min))

testPropertyWithConfig
config10k
"minBy with identity projection returns minimum element"
(Prop.forAll(neListOfInt())
<| fun nel -> NonEmptyList.minBy id nel = (nel |> NonEmptyList.toList |> List.min))

testPropertyWithConfig
config10k
"minBy with negation projection returns maximum element"
(Prop.forAll(neListOfInt())
<| fun nel -> NonEmptyList.minBy id nel = (nel |> NonEmptyList.toList |> List.min)) ]
<| fun nel -> NonEmptyList.minBy (fun x -> -x) nel = (nel |> NonEmptyList.toList |> List.max)) ]