Strengthen sortBy/maxBy/minBy tests with two distinct projections - #248
Merged
gdziadkiewicz merged 2 commits intoMar 14, 2026
Conversation
Co-authored-by: gdziadkiewicz <8547855+gdziadkiewicz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on NonEmptyList functions and tests
Strengthen sortBy/maxBy/minBy tests with two distinct projections
Mar 14, 2026
gdziadkiewicz
approved these changes
Mar 14, 2026
gdziadkiewicz
marked this pull request as ready for review
March 14, 2026 12:26
gdziadkiewicz
merged commit Mar 14, 2026
91d7a00
into
repo-assist/improve-nonemptylist-and-seq-tests-8fbc6ac826d39964
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for
sortBy,maxBy, andminBywere usingidas the projection, which can't detect bugs where the projection is silently ignored (e.g.,sortBybehaving assort).Each function now has two property-based tests using opposite projections:
The negation projection verifies the projection is genuinely applied, since a correct
maxBy (fun x -> -x)must return the minimum element.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.