Open
Conversation
This was referenced Mar 30, 2026
DelevoXDG
changed the base branch from
zdobnikau/fix-config-parsing
to
zdobnikau/fix-config-parsing-2
DelevoXDG
force-pushed
the
zdobnikau/sncast-config-docs
branch
from
ea7e126 to
3dee6ae
Compare
DelevoXDG
force-pushed
the
zdobnikau/fix-config-parsing-2
branch
2 times, most recently
from
be936a9 to
c4174c6
Compare
DelevoXDG
added a commit
that referenced
this pull request
Apr 24, 2026
<!-- Reference any GitHub issues resolved by this PR --> Closes #3811 Closes #4027 ## Stack - #4175 - #4205 - #4249 - #4234 ## Summary This PR fixes the actual bugs & issues I've been able to find, and changes the sncast handling logic in a more significant way ## Introduced changes <!-- A brief description of the changes --> - ## Checklist <!-- Make sure all of these are complete --> - [x] Linked relevant issue - [ ] Updated relevant documentation - [x] Added relevant tests - [x] Performed self-review of the code - [ ] Added changes to `CHANGELOG.md` --------- Co-authored-by: ddoktorski <45050160+ddoktorski@users.noreply.github.com>
DelevoXDG
force-pushed
the
zdobnikau/fix-config-parsing-2
branch
from
c4174c6 to
741b45c
Compare
DelevoXDG
added a commit
that referenced
this pull request
Apr 27, 2026
<!-- Reference any GitHub issues resolved by this PR --> ## Stack - #4175 - #4205 - #4249 - #4234 ## Introduced changes <!-- A brief description of the changes --> Allow configuring scarb profile separately from sncast config: - `--scarb-profile` in cli - `scarb-profile` in `snfoundry.toml` ## Checklist <!-- Make sure all of these are complete --> - [ ] Linked relevant issue - [x] Updated relevant documentation - [ ] Added relevant tests - [x] Performed self-review of the code - [x] Added changes to `CHANGELOG.md`
DelevoXDG
force-pushed
the
zdobnikau/sncast-config-docs
branch
from
3dee6ae to
a21ac6e
Compare
<!-- Reference any GitHub issues resolved by this PR --> ## Stack - #4175 - #4205 - #4249 - #4234 ## Introduced changes <!-- A brief description of the changes --> Allow configuring scarb profile separately from sncast config: - `--scarb-profile` in cli - `scarb-profile` in `snfoundry.toml` ## Checklist <!-- Make sure all of these are complete --> - [ ] Linked relevant issue - [x] Updated relevant documentation - [ ] Added relevant tests - [x] Performed self-review of the code - [x] Added changes to `CHANGELOG.md`
DelevoXDG
force-pushed
the
zdobnikau/sncast-config-docs
branch
from
e3dac50 to
4109459
Compare
die-herdplatte
pushed a commit
to die-herdplatte/starknet-foundry
that referenced
this pull request
Apr 29, 2026
<!-- Reference any GitHub issues resolved by this PR --> Towards foundry-rs#4027 ## Stack - foundry-rs#4175 - foundry-rs#4205 - foundry-rs#4249 - foundry-rs#4234 ## Introduced changes <!-- A brief description of the changes --> #### Outline This is initial refactor of cast config handling. It aims to make the logic easier to reason about, removes tricky defaults resolution (using `None` instead), removes manual raw string approach config construction, and paves way for fixes introduced in foundry-rs#4205 Subsequent PR introduces more significant changes that change how configs are actually handled in more breaking way in attempt to address various issues, while this one mainly tries to keep current logic intact. #### Changes - Add `PartialCastConfig` with all fields having `None` as `Default` value. - Create global, local, cli `PartialCastConfig`. Then combine them (add `Override` trait for config and it's subcomponents) - Replace raw string approach to config in `add_created_profile_to_configuration` ## Checklist <!-- Make sure all of these are complete --> - [x] Linked relevant issue - [ ] Updated relevant documentation - [ ] Added relevant tests - [x] Performed self-review of the code - [ ] Added changes to `CHANGELOG.md` --------- Co-authored-by: Maksymilian Kowalski <126796018+MKowalski8@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP, awaiting feedback and final decisions in #4205
Stack
sncast --profile#4249Checklist
CHANGELOG.md