Fix various sncast config issues by DelevoXDG · Pull Request #4205 · foundry-rs/starknet-foundry

DelevoXDG · 2026-03-09T22:39:29Z

Closes #3811
Closes #4027

Stack

Summary

This PR fixes the actual bugs & issues I've been able to find, and changes the sncast handling logic in a more significant way

Introduced changes

Checklist

DelevoXDG · 2026-03-30T16:53:38Z

    #[test]
    fn empty_config_works() {


I'm not sure what is the intention of the original test, should we delete it?

Original PR:
https://github.com/foundry-rs/starknet-foundry/pull/1911/changes

I guess just a sanity check, leaving this up to you whether to keep it or not

ddoktorski · 2026-04-20T09:51:03Z

+            )));
+        }
+        // Note: this is potentially unreachable: `get_or_create_global_config_path` should always return dir with existing config file.
+        // TODO: (#3436) remove this if missing global config becomes an error


I'm not sure if the linked issue is accurate here as it seems very general. Also what is the actual action item here, to decide whether missing global config file should be an error?

Also what is the actual action item here, to decide whether missing global config file should be an error?

Previously, function get_global_config_path actually didn't only get the config path, but also created it, if missing. That's why I renamed it.

The original logic though allowed us to continue, even if global config is missing for some reason.

The reason for my comment is that described situation ("global config is missing") shouldn't really happen, at least in normal (non-error) circumstances, since we always create the dir instead.

There are some cases where it can:

Missing HOME dir on the os

Some fs permission issues, disallowing us from creating config file

So the question is:

Should we proceed execution in these cases, as was done before?

Or should we treat these as hard errors?

If we treat them as hard errors, then all these global_maybe_config == MaybeConfig::NoFile cases become effectively unreachable.

If we keep it as it, we:

treat them as errors when unable to resolve requested --profile

proceed execution with a warning otherwise

I think I attached the wrong issue though, it was planned to be handled under now closed #4184

Since this is getting very confusing, I suggest we either create a new issue, or (even better imo) decide on the final approach now 😄

As discussed offline I'd lean towards a hard error, but given that so far we proceeded in such cases it also makes perfect sense to only display a warning. Both options work for me, let's choose one of these and address it in scope of this or next PR

ddoktorski · 2026-04-20T09:58:14Z

    #[test]
    fn empty_config_works() {


I guess just a sanity check, leaving this up to you whether to keep it or not

- regular `runner` uses tempdir (so effectively empty global config; previously: dependend on local machine) - allows overriding global config dir (previously: no mechanism to test global config)

Co-authored-by: ddoktorski <45050160+ddoktorski@users.noreply.github.com>

…hen `local.profile` is missing

## Stack - #4175 - #4205 - #4249 - #4234 ## Introduced changes  Allow configuring scarb profile separately from sncast config: - `--scarb-profile` in cli - `scarb-profile` in `snfoundry.toml` ## Checklist  - [ ] Linked relevant issue - [x] Updated relevant documentation - [ ] Added relevant tests - [x] Performed self-review of the code - [x] Added changes to `CHANGELOG.md`

Towards foundry-rs#4027 ## Stack - foundry-rs#4175 - foundry-rs#4205 - foundry-rs#4249 - foundry-rs#4234 ## Introduced changes  #### Outline This is initial refactor of cast config handling. It aims to make the logic easier to reason about, removes tricky defaults resolution (using `None` instead), removes manual raw string approach config construction, and paves way for fixes introduced in foundry-rs#4205 Subsequent PR introduces more significant changes that change how configs are actually handled in more breaking way in attempt to address various issues, while this one mainly tries to keep current logic intact. #### Changes - Add `PartialCastConfig` with all fields having `None` as `Default` value. - Create global, local, cli `PartialCastConfig`. Then combine them (add `Override` trait for config and it's subcomponents) - Replace raw string approach to config in `add_created_profile_to_configuration` ## Checklist  - [x] Linked relevant issue - [ ] Updated relevant documentation - [ ] Added relevant tests - [x] Performed self-review of the code - [ ] Added changes to `CHANGELOG.md` --------- Co-authored-by: Maksymilian Kowalski <126796018+MKowalski8@users.noreply.github.com>

DelevoXDG mentioned this pull request Mar 20, 2026

Refactor sncast config logic #4175

Merged

5 tasks

DelevoXDG force-pushed the zdobnikau/fix-config-parsing branch from 62ed83f to 4ee68c8 Compare March 23, 2026 12:54

DelevoXDG mentioned this pull request Mar 30, 2026

Docs: sncast config changes #4234

Open

2 tasks

DelevoXDG changed the title ~~(wip) Fix various sncast config issues~~ Fix various sncast config issues Mar 30, 2026

DelevoXDG marked this pull request as ready for review March 30, 2026 17:13

DelevoXDG requested review from a team, ddoktorski and franciszekjob and removed request for a team March 30, 2026 17:13

DelevoXDG commented Mar 30, 2026

View reviewed changes

DelevoXDG mentioned this pull request Apr 5, 2026

Separate Scarb profile used from sncast --profile #4249

Merged

5 tasks

DelevoXDG mentioned this pull request Apr 13, 2026

Skip config loading for sncast completions #4272

Open

5 tasks

franciszekjob reviewed Apr 16, 2026

View reviewed changes

Comment thread crates/sncast/src/helpers/configuration.rs Outdated

Comment thread crates/sncast/src/helpers/config.rs Outdated

Comment thread crates/sncast/tests/e2e/show_config.rs

Comment thread crates/sncast/src/main.rs Outdated

DelevoXDG force-pushed the zdobnikau/refactor-sncast-config branch from 23de475 to 40addaf Compare April 17, 2026 14:05

DelevoXDG force-pushed the zdobnikau/fix-config-parsing branch from 24224a4 to 93b4912 Compare April 17, 2026 14:15

ddoktorski reviewed Apr 20, 2026

View reviewed changes

DelevoXDG force-pushed the zdobnikau/fix-config-parsing branch from 793e730 to 1978e97 Compare April 20, 2026 11:07

DelevoXDG requested review from ddoktorski and franciszekjob April 21, 2026 11:19

ddoktorski approved these changes Apr 21, 2026

View reviewed changes

franciszekjob approved these changes Apr 22, 2026

View reviewed changes

Comment thread crates/sncast/src/main.rs Outdated

Base automatically changed from zdobnikau/refactor-sncast-config to master April 23, 2026 12:44

DelevoXDG added 8 commits April 23, 2026 17:17

allow overriding global config path via SNFOUNDRY_CONFIG

7e4bbb8

fix cast test runner <> global config

a66098a

- regular `runner` uses tempdir (so effectively empty global config; previously: dependend on local machine) - allows overriding global config dir (previously: no mechanism to test global config)

partial refactor (wip)

f3a1268

updating tests...

5cdb437

formatting...

4e44b98

fix: disallow invalid fields

b2b12f2

add global config tests

9f60743

update provider error handling in show-config

da4f394

DelevoXDG and others added 21 commits April 23, 2026 17:17

fix test asserts

d1cb44c

misc

8fd3637

add missing test file

1de868d

post-rebase test fix

438bfea

improve message on invalid effective config

c962b0a

format and other fixes

d24cbfc

allow non-existent profile (pass test_using_release_profile)

99906b2

add pending TODO

24d9557

misc

92a74e7

misc

e630f6e

apply discussed global-config change

012979e

validate effective config in `CastConfig::try_from(PartialCastConfig)

c5748a6

use NonZero types; add serde_path_to_error for fuller error messages

755fa46

improve error message

ad207be

use enum for config scope

82ed178

rename env

9199ab7

format

f2bb7f2

apply nitpick

032bacc

Co-authored-by: ddoktorski <45050160+ddoktorski@users.noreply.github.com>

allow & use local.default -> global.profile -> global.default w…

56ec435

…hen `local.profile` is missing

separately handle PartialWaitParams validation; allow partial configs

1fc5689

avoid loading profile when no profile is specified

6894e2e

DelevoXDG force-pushed the zdobnikau/fix-config-parsing branch from a697315 to 6894e2e Compare April 23, 2026 13:18

DelevoXDG added 3 commits April 24, 2026 01:09

post-rebase fix

5e30fdc

fix test_show_config_cli_url_overrides_config_network

fdf2d67

format

afceec9

DelevoXDG merged commit 423e9a7 into master Apr 24, 2026
24 of 25 checks passed

DelevoXDG deleted the zdobnikau/fix-config-parsing branch April 24, 2026 08:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix various sncast config issues#4205

Fix various sncast config issues#4205
DelevoXDG merged 41 commits intomasterfrom
zdobnikau/fix-config-parsing

DelevoXDG commented Mar 9, 2026 •

edited

Loading

Uh oh!

DelevoXDG Mar 30, 2026

Uh oh!

ddoktorski Apr 20, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ddoktorski Apr 20, 2026

Uh oh!

DelevoXDG Apr 20, 2026 •

edited

Loading

Uh oh!

ddoktorski Apr 21, 2026

Uh oh!

Uh oh!

ddoktorski Apr 20, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

DelevoXDG commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Stack

Summary

Introduced changes

Checklist

Uh oh!

DelevoXDG Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

ddoktorski Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ddoktorski Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

DelevoXDG Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ddoktorski Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ddoktorski Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

DelevoXDG commented Mar 9, 2026 •

edited

Loading

DelevoXDG Apr 20, 2026 •

edited

Loading