Skip to content

Shape v8 runtime graph contract#463

Merged
flyingrobots merged 2 commits into
mainfrom
cycle/v8-runtime-graph-contract-457
Jul 5, 2026
Merged

Shape v8 runtime graph contract#463
flyingrobots merged 2 commits into
mainfrom
cycle/v8-runtime-graph-contract-457

Conversation

@flyingrobots

@flyingrobots flyingrobots commented Jul 5, 2026

Copy link
Copy Markdown
Owner

Summary

Refs #457.

Validation

  • npx vitest run --config vitest.config.ts tests/cycles/WF-126/v7-closeout-tracker-sync.test.ts tests/cycles/WF-130/roadmap-goalpost-policy.part01.test.ts tests/cycles/WF-130/roadmap-goalpost-policy.part02.test.ts tests/cycles/WF-130/roadmap-goalpost-policy.part03.test.ts
  • npm run docs:inventory
  • npm run typecheck:test
  • npm run lint
  • npm run code-dojo:changed
  • git diff --check
  • Pre-push full verification, including DOGFOOD i18n gates, code size, typecheck, all 19 Vitest chunks, and scripted interactive example smokes

Summary by CodeRabbit

  • New Features

    • Added release documentation for the upcoming V8 runtime graph and scene contract work, including clearer rollout guidance and validation expectations.
    • Expanded the 7.2.0 release notes and overview to include finalized release evidence and registry verification details.
  • Documentation

    • Updated roadmap and bearing guidance to reflect the new near-term focus and recommended work order.
    • Added a new design note describing release acceptance criteria and checks.
  • Tests

    • Updated automated checks to match the revised release and documentation expectations.

@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@flyingrobots, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 43 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 39245119-ad07-4f87-ab3f-a8b7a129c102

📥 Commits

Reviewing files that changed from the base of the PR and between 3a4d956 and dfdff46.

📒 Files selected for processing (4)
  • docs/design/DX-048-v8-runtime-graph-scene-ir-contract.md
  • docs/releases/7.2.0/README.md
  • tests/cycles/WF-130/roadmap-goalpost-policy.part01.test.ts
  • tests/cycles/WF-130/roadmap-goalpost-policy.part03.test.ts
📝 Walkthrough

Walkthrough

Updates BEARING.md and CHANGELOG.md to redirect focus toward shaping the V8 Runtime Graph and Scene IR product contract (#457), adds a new DX-048 design document defining that contract, revises 7.2.0 release evidence docs for final tag provenance wording, and updates related roadmap-goalpost tests.

Changes

V8 Runtime Graph contract shaping

Layer / File(s) Summary
DX-048 design document
docs/design/DX-048-v8-runtime-graph-scene-ir-contract.md
New document defining the artifact chain, receipt gate, failure criteria, posture constraints, and implementation plan tied to #457/#458/#459.
BEARING and CHANGELOG target updates
docs/BEARING.md, docs/CHANGELOG.md
Next Target and Recommended pull order shift to #457-centered V8 work; CHANGELOG adds an Unreleased entry and compare link referencing DX-048.
Roadmap-goalpost test updates
tests/cycles/WF-130/roadmap-goalpost-policy.part01.test.ts
Adds DX-048 fixture reads and content assertions, updates bearing assertions for the new #457 target, and checks the DX-048 roadmap link.

7.2.0 release evidence provenance updates

Layer / File(s) Summary
Release README provenance rewrite
docs/releases/7.2.0/README.md
Updates release summary, replay instructions, evidence matrix, review matrix, verification plan, and residual risk to describe final tag creation from a verified main commit.
Migration guide and whats-new wording
docs/releases/7.2.0/migration-guide.md, docs/releases/7.2.0/whats-new.md
Reworks public-tag provenance description and release tooling/evidence enumeration.
Release packet test assertions
tests/cycles/WF-130/roadmap-goalpost-policy.part03.test.ts
Replaces regex check with explicit string assertions for tag URL, publish date, and registry verification, plus negative checks.

Estimated code review effort: 2 (Simple) | ~15 minutes

Possibly related PRs

  • flyingrobots/bijou#452: Both PRs modify the same roadmap-goalpost validation surface—updating BEARING.md and part01 test expectations around the v7.2→V8 contract work.

Suggested labels: type:maintenance, legend:wf

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and accurately reflects the PR’s main change: shaping the V8 runtime graph contract.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cycle/v8-runtime-graph-contract-457

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@flyingrobots

Copy link
Copy Markdown
Owner Author

Code Lawyer Self-Review

Cc: @codex please sanity-check these findings.

Lockdown:

  • git status --porcelain was clean before review.
  • git fetch origin --tags --prune completed before diff review.
  • Reviewed git diff origin/main...HEAD for PR Shape v8 runtime graph contract #463.

Findings

Severity File Lines Type Finding Mitigation prompt
P2 docs/releases/7.2.0/README.md 331-345 Release evidence determinism The v7.2 packet now records npm registry verification as shipped evidence, but the only retained proof is a set of live npm view <package> version dist-tags --json commands. Those commands are time-dependent: after the next publish, they will report the new latest, not the release-time v7.2 state, so this historical evidence packet loses replay value. Update the v7.2 release packet to capture immutable release-time registry evidence: add a dated verification table or JSON block listing each package, observed version: 7.2.0, observed latest: 7.2.0, and verification timestamp/run context. Keep the live npm view commands as operational replay commands, but do not make them the sole evidence for a historical release claim. Update WF-130 assertions so the packet must contain the captured snapshot, not just mutable commands.
P5 docs/design/DX-048-v8-runtime-graph-scene-ir-contract.md 31 Markdown style The new design doc uses a bare URL for the VISOR coordination surface. The repo's .markdownlint.json keeps default rules enabled and only disables line length, so this trips MD034/no-bare-urls. Nearby release docs use autolinks such as <https://...>. Replace the bare URL with a named Markdown link or autolink, e.g. VISOR coordination surface: [flyingrobots/visor](https://github.com/flyingrobots/visor).

Issue Count

Severity Count
P2 1
P5 1

Validation Context

  • GitHub Actions are green for PR Shape v8 runtime graph contract #463.
  • CodeRabbit status is green.
  • Review threads are currently zero.
  • Auxiliary markdown check: npx markdownlint-cli2 ... reports many legacy changelog/style failures; the actionable new-doc finding above is the MD034 bare URL at DX-048 line 31.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3a4d956c99

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/releases/7.2.0/README.md
Comment thread docs/design/DX-048-v8-runtime-graph-scene-ir-contract.md Outdated
@flyingrobots

Copy link
Copy Markdown
Owner Author

Review Resolution

Resolved both self-review findings in dfdff46b.

Severity File Resolution
P2 docs/releases/7.2.0/README.md Added Release-Time Registry Snapshot with immutable package/version/latest evidence for every published package, plus Release workflow run 28736930944, completion time 2026-07-05T10:03:04Z, and release commit 123f4a6150963932118cbf763a8a6ec03487e227. The live npm view commands are now explicitly replay aids, not the sole historical evidence.
P5 docs/design/DX-048-v8-runtime-graph-scene-ir-contract.md Replaced the bare VISOR URL with a named Markdown link and added a WF-130 guard against the bare-URL form.

Validation:

  • npx vitest run --config vitest.config.ts tests/cycles/WF-126/v7-closeout-tracker-sync.test.ts tests/cycles/WF-130/roadmap-goalpost-policy.part01.test.ts tests/cycles/WF-130/roadmap-goalpost-policy.part02.test.ts tests/cycles/WF-130/roadmap-goalpost-policy.part03.test.ts
  • npm run docs:inventory
  • npm run typecheck:test
  • npm run lint
  • npm run code-dojo:changed
  • git diff --check
  • bare VISOR URL regression grep
  • full pre-push verification, including DOGFOOD i18n gates, code size, typecheck, all 19 Vitest chunks, and scripted interactive example smokes

GitHub Actions are running again for the new commit; local and pre-push validation are green.

@flyingrobots
flyingrobots merged commit ef2ff00 into main Jul 5, 2026
10 checks passed
@flyingrobots
flyingrobots deleted the cycle/v8-runtime-graph-contract-457 branch July 5, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant