Skip to content

deps: Update dependency toolchains_llvm to v1.8.0 #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ffortier wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

deps: Update dependency toolchains_llvm to v1.8.0 #797

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion third_party/cpp/toolchains.MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
bazel_dep(name = "toolchains_llvm", version = "1.7.0")
bazel_dep(name = "toolchains_llvm", version = "1.8.0")

@coderabbitai coderabbitai Bot Jul 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
fd -H -a '(\.bazelversion|WORKSPACE|MODULE\.bazel|.*\.yml|.*\.yaml|Dockerfile)$' \
  | xargs -r rg -n -i 'bazel(version)?|bazelisk'

Repository: ffortier/mono

Length of output: 9438

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== tracked bazel/version-related files =="
git ls-files | rg '(^|/)(\.bazelversion|WORKSPACE|MODULE\.bazel|\.github/workflows/ci\.ya?ml|Dockerfile)$' || true

echo
echo "== relevant config snippets =="
for f in $(git ls-files | rg '(^|/)(\.bazelversion|WORKSPACE|MODULE\.bazel|\.github/workflows/ci\.ya?ml|Dockerfile)$'); do
  echo "--- $f"
  sed -n '1,140p' "$f"
done

echo
echo "== Bazel/version references with context =="
git ls-files | xargs -r rg -n -i 'bazel-version|bazelversion|bazelisk|bazel:|Bazel|7\.0\.0|toolchains_llvm' || true

Repository: ffortier/mono

Length of output: 50370

🌐 Web query:

bazel-contrib toolchains_llvm 1.8.0 minimum Bazel version

💡 Result:

The minimum Bazel version required for bazel-contrib/toolchains_llvm version 1.8.0 is 7.0.0 [1][2][3].

Citations:

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== tracked bazel files =="
git ls-files '^(\.bazelversion|WORKSPACE|MODULE\.bazel|MODULE\.bazel\.lock)$' | while read -r f; do
  echo "--- $f"
  awk '
    /.bazel_version/ || /compatible_with/ || /^bazel_dep/ || /^module_deps/ { print }
  ' "$f" | head -n 200 || true
done

echo
echo "== version-specific tracked files if present =="
git ls-files | awk -F/ '$(NF-1) ~ /^[.]github$/ {print $0}' | rg '(^|/)(\.bazelversion|WORKSPACE|MODULE\.bazel|.*\.ya?ml|Dockerfile)$' || true
for f in $(git ls-files | awk -F/ '$(NF-1) ~ /^[.]github$/ {print $0}' | rg '(^|/)(\.bazelversion|WORKSPACE|MODULE\.bazel|.*\.ya?ml|Dockerfile)$'); do
  echo "--- $f"
  rg -n -i 'bazel(-version)?|bazelisk' "$f" || true
done

echo
echo "== direct version references in workspace/config files =="
git ls-files '^(\.bazelversion|WORKSPACE|MODULE\.bazel)$' \
  $(git ls-files | awk -F/ '$(NF-1) ~ /^[.]github$/ {print $0}' | rg '(^|/)(\.bazelversion|WORKSPACE|MODULE\.bazel|.*\.ya?ml|Dockerfile)$') \
  | xargs -r rg -n -i 'bazel(-version)?|bazelisk' || true

Repository: ffortier/mono

Length of output: 285

Declare CI to use Bazel 7.0.0+ for toolchains_llvm 1.8.0

.github/workflows/ci.yml installs bazelisk but does not pin or select a Bazel version, so CI does not guarantee the toolchains_llvm/1.8.0 Bazel 7.0.0 minimum. Add/refresh a .bazelversion or explicit workflow selector and recompute MODULE.bazel.lock at that Bazel version if it’s currently based on an older binary.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@third_party/cpp/toolchains.MODULE.bazel` at line 1, Ensure CI selects Bazel
7.0.0 or newer for the toolchains_llvm dependency declared in
toolchains.MODULE.bazel by adding or updating the repository’s .bazelversion or
an explicit selector in the CI workflow. If MODULE.bazel.lock was generated with
an older Bazel binary, regenerate it using the selected Bazel version.

bazel_dep(name = "rules_cc", version = "0.2.17")

# Fixes https://github.com/bazel-contrib/toolchains_llvm/issues/547
Expand Down
Loading