deps: Update dependency toolchains_llvm to v1.8.0#797
Conversation
📝 WalkthroughWalkthroughThe Bazel module dependency for ChangesToolchains LLVM Upgrade
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
c5a3fc3 to
dba38d1
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@third_party/cpp/toolchains.MODULE.bazel`:
- Line 1: Ensure CI selects Bazel 7.0.0 or newer for the toolchains_llvm
dependency declared in toolchains.MODULE.bazel by adding or updating the
repository’s .bazelversion or an explicit selector in the CI workflow. If
MODULE.bazel.lock was generated with an older Bazel binary, regenerate it using
the selected Bazel version.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 89ef6dd8-85d7-4252-81db-5f14d899ece4
📒 Files selected for processing (1)
third_party/cpp/toolchains.MODULE.bazel
| @@ -1,4 +1,4 @@ | |||
| bazel_dep(name = "toolchains_llvm", version = "1.7.0") | |||
| bazel_dep(name = "toolchains_llvm", version = "1.8.0") | |||
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
fd -H -a '(\.bazelversion|WORKSPACE|MODULE\.bazel|.*\.yml|.*\.yaml|Dockerfile)$' \
| xargs -r rg -n -i 'bazel(version)?|bazelisk'Repository: ffortier/mono
Length of output: 9438
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== tracked bazel/version-related files =="
git ls-files | rg '(^|/)(\.bazelversion|WORKSPACE|MODULE\.bazel|\.github/workflows/ci\.ya?ml|Dockerfile)$' || true
echo
echo "== relevant config snippets =="
for f in $(git ls-files | rg '(^|/)(\.bazelversion|WORKSPACE|MODULE\.bazel|\.github/workflows/ci\.ya?ml|Dockerfile)$'); do
echo "--- $f"
sed -n '1,140p' "$f"
done
echo
echo "== Bazel/version references with context =="
git ls-files | xargs -r rg -n -i 'bazel-version|bazelversion|bazelisk|bazel:|Bazel|7\.0\.0|toolchains_llvm' || trueRepository: ffortier/mono
Length of output: 50370
🌐 Web query:
bazel-contrib toolchains_llvm 1.8.0 minimum Bazel version
💡 Result:
The minimum Bazel version required for bazel-contrib/toolchains_llvm version 1.8.0 is 7.0.0 [1][2][3].
Citations:
- 1: https://github.com/bazel-contrib/toolchains_llvm/releases/tag/v1.8.0
- 2: https://github.com/bazel-contrib/toolchains_llvm/releases
- 3: https://newreleases.io/project/github/bazel-contrib/toolchains_llvm/release/v1.8.0
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== tracked bazel files =="
git ls-files '^(\.bazelversion|WORKSPACE|MODULE\.bazel|MODULE\.bazel\.lock)$' | while read -r f; do
echo "--- $f"
awk '
/.bazel_version/ || /compatible_with/ || /^bazel_dep/ || /^module_deps/ { print }
' "$f" | head -n 200 || true
done
echo
echo "== version-specific tracked files if present =="
git ls-files | awk -F/ '$(NF-1) ~ /^[.]github$/ {print $0}' | rg '(^|/)(\.bazelversion|WORKSPACE|MODULE\.bazel|.*\.ya?ml|Dockerfile)$' || true
for f in $(git ls-files | awk -F/ '$(NF-1) ~ /^[.]github$/ {print $0}' | rg '(^|/)(\.bazelversion|WORKSPACE|MODULE\.bazel|.*\.ya?ml|Dockerfile)$'); do
echo "--- $f"
rg -n -i 'bazel(-version)?|bazelisk' "$f" || true
done
echo
echo "== direct version references in workspace/config files =="
git ls-files '^(\.bazelversion|WORKSPACE|MODULE\.bazel)$' \
$(git ls-files | awk -F/ '$(NF-1) ~ /^[.]github$/ {print $0}' | rg '(^|/)(\.bazelversion|WORKSPACE|MODULE\.bazel|.*\.ya?ml|Dockerfile)$') \
| xargs -r rg -n -i 'bazel(-version)?|bazelisk' || trueRepository: ffortier/mono
Length of output: 285
Declare CI to use Bazel 7.0.0+ for toolchains_llvm 1.8.0
.github/workflows/ci.yml installs bazelisk but does not pin or select a Bazel version, so CI does not guarantee the toolchains_llvm/1.8.0 Bazel 7.0.0 minimum. Add/refresh a .bazelversion or explicit workflow selector and recompute MODULE.bazel.lock at that Bazel version if it’s currently based on an older binary.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@third_party/cpp/toolchains.MODULE.bazel` at line 1, Ensure CI selects Bazel
7.0.0 or newer for the toolchains_llvm dependency declared in
toolchains.MODULE.bazel by adding or updating the repository’s .bazelversion or
an explicit selector in the CI workflow. If MODULE.bazel.lock was generated with
an older Bazel binary, regenerate it using the selected Bazel version.
dba38d1 to
16fd37c
Compare
This PR contains the following updates:
1.7.0→1.8.0Release Notes
bazel-contrib/toolchains_llvm (toolchains_llvm)
v1.8.0Minimum bazel version: 7.0.0
If you're using
bzlmod, add the following toMODULE.bazel:To directly use a commit from GitHub, add this block and replace commit with the commit you want.
If not using
bzlmod, include this section in yourWORKSPACE:What's Changed
link_libsforlibstdc++by @phlax in #625New Contributors
Full Changelog: bazel-contrib/toolchains_llvm@v1.7.0...v1.8.0
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate.