feat: dynamic backends clientCertificate with SecretStore fromBytes, rawbytes #796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottt
reviewed
Jun 3, 2024
elliottt
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #794. API as per
types/backend.d.ts.SecretStore is extended to support
SecretStore.fromBytesandSecretStoreEntry.prototype.rawbytes()to get the raw buffer for a secret instead of the UTF8 encoding.The new client cert option is then implemented for dynamic backends taking an object with a
certificatestring andkeySecretStoreEntryproperties, with error handling.This PR also updates to the latest wit-bindgen, regenerating the world, and reenables the secret store tests which got dropped in the refactoring PR in #673.