Fix oss build #309
Closed
Fix oss build #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@georges-berenger has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87478397. |
georges-berenger
force-pushed
the
export-D87478397
branch
from
b82d0db to
a5173b1
Compare
georges-berenger
pushed a commit
to georges-berenger/pyvrs
that referenced
this pull request
Nov 19, 2025
Summary: Fix pyvrs oss build. Differential Revision: D87478397
georges-berenger
pushed a commit
to georges-berenger/pyvrs
that referenced
this pull request
Nov 19, 2025
Summary: Fix pyvrs oss build. Differential Revision: D87478397
georges-berenger
force-pushed
the
export-D87478397
branch
from
a5173b1 to
5947f95
Compare
georges-berenger
pushed a commit
to georges-berenger/pyvrs
that referenced
this pull request
Nov 20, 2025
Summary: Fix pyvrs oss build. Differential Revision: D87478397
georges-berenger
force-pushed
the
export-D87478397
branch
from
5947f95 to
e41f159
Compare
georges-berenger
pushed a commit
to georges-berenger/pyvrs
that referenced
this pull request
Nov 20, 2025
Summary: Fix pyvrs oss build. Differential Revision: D87478397
georges-berenger
force-pushed
the
export-D87478397
branch
from
e41f159 to
e1dac63
Compare
georges-berenger
pushed a commit
to georges-berenger/pyvrs
that referenced
this pull request
Nov 20, 2025
Summary: Fix pyvrs oss build. Differential Revision: D87478397
georges-berenger
pushed a commit
to georges-berenger/pyvrs
that referenced
this pull request
Nov 20, 2025
Summary: Fix pyvrs oss build. Differential Revision: D87478397
georges-berenger
force-pushed
the
export-D87478397
branch
from
e1dac63 to
d1e0517
Compare
georges-berenger
pushed a commit
to georges-berenger/pyvrs
that referenced
this pull request
Nov 20, 2025
Summary: Fix pyvrs oss build. Differential Revision: D87478397
georges-berenger
force-pushed
the
export-D87478397
branch
2 times, most recently
from
bc1e481 to
397741d
Compare
georges-berenger
pushed a commit
to georges-berenger/pyvrs
that referenced
this pull request
Nov 20, 2025
Summary: Fix pyvrs oss build. Differential Revision: D87478397
georges-berenger
pushed a commit
to georges-berenger/pyvrs
that referenced
this pull request
Nov 21, 2025
Summary: Fix pyvrs oss build. Differential Revision: D87478397
georges-berenger
force-pushed
the
export-D87478397
branch
2 times, most recently
from
4bfe65a to
6924818
Compare
georges-berenger
pushed a commit
to georges-berenger/pyvrs
that referenced
this pull request
Nov 21, 2025
Summary: Add a number of OSS issues that accumulated over time: - extractAudio was added, but can't be used in oss from its location (linkage issues). Disabling in pyvrs/oss for now. - properly exposed writer functionality in oss - back-ported cmake install workaround from the vrs/oss repo Differential Revision: D87478397
georges-berenger
force-pushed
the
export-D87478397
branch
from
6924818 to
7438cc6
Compare
georges-berenger
pushed a commit
to georges-berenger/pyvrs
that referenced
this pull request
Nov 22, 2025
Summary: Add a number of OSS issues that accumulated over time: - extractAudio was added, but can't be used in oss from its location (linkage issues). Disabling in pyvrs/oss for now. - properly exposed writer functionality in oss - back-ported cmake install workaround from the vrs/oss repo Differential Revision: D87478397
Summary: Add a number of OSS issues that accumulated over time: - extractAudio was added, but can't be used in oss from its location (linkage issues). Disabling in pyvrs/oss for now. - back-ported cmake install workaround from the vrs/oss repo Differential Revision: D87478397
georges-berenger
force-pushed
the
export-D87478397
branch
from
7438cc6 to
a9fb54b
Compare
georges-berenger
pushed a commit
to georges-berenger/pyvrs
that referenced
this pull request
Nov 22, 2025
Summary: Add a number of OSS issues that accumulated over time: - extractAudio was added, but can't be used in oss from its location (linkage issues). Disabling in pyvrs/oss for now. - back-ported cmake install workaround from the vrs/oss repo Differential Revision: D87478397
|
This pull request has been merged in e9e062f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fix pyvrs oss build.
Differential Revision: D87478397