Skip to content

Commit 397741d

Browse files
Georges Berengerfacebook-github-bot
authored andcommitted
Fix oss build (#309)
Summary: Fix pyvrs oss build. Differential Revision: D87478397
1 parent 7bea5e7 commit 397741d

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

.github/workflows/build-and-test.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,9 @@ jobs:
3939
python -m pip install pybind11[global]
4040
4141
elif [ "$RUNNER_OS" == "macOS" ]; then
42-
brew install cmake git ninja googletest glog fmt \
42+
# Update or install cmake
43+
brew upgrade cmake || brew install cmake
44+
brew install git ninja googletest glog fmt \
4345
jpeg-turbo libpng \
4446
lz4 zstd xxhash \
4547
boost \

cmake/LibrariesSetup.cmake

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,15 @@ if (EXISTS "$ENV{HOME}/homebrew")
1717
list(APPEND CMAKE_FIND_ROOT_PATH "$ENV{HOME}/homebrew")
1818
endif()
1919

20-
find_package(Boost REQUIRED
20+
find_package(Boost
2121
COMPONENTS
2222
filesystem
2323
chrono
2424
date_time
2525
system
2626
thread
27+
CONFIG
28+
REQUIRED
2729
)
2830
find_package(Eigen REQUIRED)
2931
find_package(FmtLib REQUIRED)

csrc/Pybind11.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,13 @@
2222
#include "VrsBindings.h"
2323
#include "reader/Reader.h"
2424
#include "utils/Utils.h"
25+
#include "writer/Writer.h"
2526

2627
#if IS_VRS_FB_INTERNAL()
2728
#include "archive/Archive.h"
2829
#include "fb/FbInternal.h"
2930
#include "fb/dataset_snapshot/PyDatasetSnapshot.h"
3031
#include "filter/Filter.h" // Disable filter internally until AsyncImageFilter is reworked.
31-
#include "writer/Writer.h"
3232
#endif
3333

3434
#ifndef PYBIND_MODULE_NAME
@@ -59,9 +59,9 @@ PYBIND11_MODULE(PYBIND_MODULE_NAME, m) {
5959
pyvrs::pybind_fbinternal(m);
6060
#endif
6161
pyvrs::pybind_reader(m);
62+
pyvrs::pybind_writer(m);
6263
#if IS_VRS_FB_INTERNAL()
6364
pyvrs::pybind_filter(m); // Disable filter internally until AsyncImageFilter is reworked.
64-
pyvrs::pybind_writer(m);
6565
pyvrs::pybind_archive(m);
6666
pyvrs::pybind_dataset_snapshot(m);
6767
#endif

0 commit comments

Comments
 (0)