Skip to content

Split disallowed properties (keys) in stylex into stylex-no-disallowed-properties.js #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jcperez-ch wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Split disallowed properties (keys) in stylex into stylex-no-disallowed-properties.js #1296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
597 changes: 597 additions & 0 deletions packages/@stylexjs/eslint-plugin/__tests__/stylex-no-disallowed-properties-test.js
View file
Open in desktop

Large diffs are not rendered by default.

91 changes: 1 addition & 90 deletions packages/@stylexjs/eslint-plugin/__tests__/stylex-valid-styles-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -852,59 +852,6 @@ eslintTester.run('stylex-valid-styles', rule.default, {
},
],
},
{
code: "import * as stylex from '@stylexjs/stylex'; stylex.create({default: {textAlin: 'left'}});",
errors: [
{
message: 'This is not a key that is allowed by stylex',
suggestions: [
{
desc: 'Did you mean "textAlign"?',
output:
"import * as stylex from '@stylexjs/stylex'; stylex.create({default: {textAlign: 'left'}});",
},
],
},
],
},
{
code: "import * as stylex from '@stylexjs/stylex'; stylex.create({default: {marginStart: 10}});",
errors: [
{
message: 'This is not a key that is allowed by stylex',
},
],
},
{
code: "import * as stylex from '@stylexjs/stylex'; stylex.create({default: {textAlin: 'left'}});",
errors: [
{
message: 'This is not a key that is allowed by stylex',
suggestions: [
{
desc: 'Did you mean "textAlign"?',
output:
"import * as stylex from '@stylexjs/stylex'; stylex.create({default: {textAlign: 'left'}});",
},
],
},
],
},
{
code: "import * as stylex from '@stylexjs/stylex'; stylex.create({default: {[\"textAlin\"]: 'left'}});",
errors: [
{
message: 'This is not a key that is allowed by stylex',
suggestions: [
{
desc: 'Did you mean "textAlign"?',
output:
"import * as stylex from '@stylexjs/stylex'; stylex.create({default: {[\"textAlign\"]: 'left'}});",
},
],
},
],
},
{
code: "import * as stylex from '@stylexjs/stylex'; stylex.create({default: {textAlign: 'lfet'}});",
errors: [
Expand Down Expand Up @@ -958,15 +905,6 @@ revert`,
},
],
},
{
code: "import * as stylex from '@stylexjs/stylex'; stylex.create({default: {':hover': {textAlin: 'left'}}});",
options: [{ allowOuterPseudoAndMedia: true }],
errors: [
{
message: 'This is not a key that is allowed by stylex',
},
],
},
{
code: "import * as stylex from '@stylexjs/stylex'; stylex.create({default: {':focus': {textAlign: 'lfet'}}});",
options: [{ allowOuterPseudoAndMedia: true }],
Expand Down Expand Up @@ -1705,18 +1643,6 @@ eslintTester.run('stylex-valid-styles [restrictions]', rule.default, {
},
});`,
},
// test for allowed raw CSS variable overrides
{
code: `
import * as stylex from '@stylexjs/stylex';
const styles = stylex.create({
foo: {
'--bar': '0',
}
})
`,
options: [{ allowRawCSSVars: true }],
},
{
code: `
import * as stylex from '@stylexjs/stylex';
Expand Down Expand Up @@ -2121,22 +2047,7 @@ revert`,
],
},
// test for disallowed raw CSS variable overrides
{
code: `
import * as stylex from '@stylexjs/stylex';
const styles = stylex.create({
foo: {
'--bar': '0',
Copy link
Member

@mellyeliu mellyeliu Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, we likely want to keep this in the original valid-styles rule, as CSS variable overrides aren't really a CSS property

}
})
`,
options: [{ allowRawCSSVars: false }],
errors: [
{
message: 'This is not a key that is allowed by stylex',
},
],
},

{
code: `
import * as stylex from '@stylexjs/stylex';
Expand Down
Loading