Split disallowed properties (keys) in stylex into stylex-no-disallowed-properties.js

[jcperez-ch]

What changed / motivation ?

We wan to split fixable rules related to disallowed properties in stylex onto a separate eslint rule, out of stylex-valid-styles.
Why? Because having fixable rules will serve as an education leverage for users to understand the pool of properties that are no valid in stylex. It will alleviate the extreme burden of checking for way too many rules with different purposes on a single eslint rule. Similar to what we did with no-nonstandard-styles rule.

It also abstracts several repeated code in functions under /utils folder, including:

• isStylexCreateDeclaration
• isStylexCreateCallee

Linked PR/Issues

Issue in progress (issue 1201).
PR Related 1246

Additional Context

Tests for the rule have also been ported from one test file to a new one

Pre-flight checklist

• I have read the contributing guidelines
  Contribution Guidelines
• Performed a self-review of my code

[github-actions]

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

[email protected] compare
node ./compare.js /tmp/tmp.4rF8sSKapT /tmp/tmp.ehYvoPMszE

Results	Base	Patch	Ratio
@stylexjs/stylex/lib/cjs/stylex.js
· compressed	1,282	1,282	1.00
· minified	4,025	4,025	1.00
@stylexjs/stylex/lib/cjs/inject.js
· compressed	1,223	1,223	1.00
· minified	3,216	3,216	1.00
benchmarks/size/.build/bundle.js
· compressed	496,650	496,650	1.00
· minified	4,847,840	4,847,840	1.00
benchmarks/size/.build/stylex.css
· compressed	99,853	99,853	1.00
· minified	747,541	747,541	1.00

[github-actions]

workflow: benchmarks/perf

Comparison of performance test results, measured in operations per second. Larger is better.

[email protected] compare
node ./compare.js /tmp/tmp.Hhc3Izm8EM /tmp/tmp.KoA8tNCpqv

Results	Base	Patch	Ratio
babel-plugin: stylex.create
· basic create	581	558	0.96	-
· complex create	169	172	1.02	+
babel-plugin: stylex.createTheme
· basic themes	416	420	1.01	+
· complex themes	40	39	0.97	-

[mellyeliu]

Great stuff! A few initial issues:

1. Looks like some of the CSS variable override checks got moved into no-disallowed-properties, that should probably stay in valid-styles
2. Also, all the disallowed properties under banPropsForLegacy should be moved under the new rule

[mellyeliu]

hmm, we likely want to keep this in the original valid-styles rule, as CSS variable overrides aren't really a CSS property