Skip to content

refactor: use cached slice in app.listen #6897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2025
Merged

refactor: use cached slice in app.listen #6897

merged 1 commit into from
Nov 23, 2025

Conversation

@Tacit1
Copy link
Contributor

@Tacit1 Tacit1 commented Nov 16, 2025

Use the existing slice variable instead of Array.prototype.slice for consistency and to avoid repeated property lookups.

No behavior change. All tests pass. Linting clean.

Closes #6896

@efekrskl efekrskl mentioned this pull request Nov 17, 2025
Closed
bjohansebas
bjohansebas approved these changes Nov 23, 2025
View reviewed changes
Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjohansebas bjohansebas merged commit 54af593 into expressjs:master Nov 23, 2025
28 checks passed
@UlisesGascon UlisesGascon mentioned this pull request Nov 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjohansebas bjohansebas bjohansebas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Minor Cleanup: Use Cached slice Reference in app.listen Implementation

2 participants

@Tacit1 @bjohansebas