refactor: use cached slice reference in app.listen #6899
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR uses the already-defined
slicereference instead ofArray.prototype.slicein theapp.listenimplementation for consistency and micro-optimization.Changes
Array.prototype.slice.call(arguments)toslice.call(arguments)inlib/application.jsRationale
Testing
All existing tests pass (1236 passing, 2 pending), including all
app.listen()tests.Closes #6896