Skip to content

[auth] logout changes #3555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
byronkarlen wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[auth] logout changes #3555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bde8bb
logout with www
byronkarlen Mar 27, 2026
eccb4de
add debug log
byronkarlen Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/eas-cli/src/user/SessionManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,16 @@ export default class SessionManager {
}

public async logoutAsync(): Promise<void> {
const sessionSecret = this.getSessionSecret();
if (sessionSecret) {
const apiV2Client = new ApiV2Client({ accessToken: null, sessionSecret });
try {
await apiV2Client.postAsync('auth/logout', { body: {} });
} catch (e) {
// Best-effort: clear the local session even if the server request fails
Copy link
Copy Markdown
Member

@ide ide Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to print the error to the debug log. This way most users don't see it but we also don't suppress the error when debugging.

Log.debug('Failed to invalidate session secret on server:', e);
}
}
this.currentActor = undefined;
await this.setSessionAsync(undefined);
}
Expand Down
32 changes: 32 additions & 0 deletions packages/eas-cli/src/user/__tests__/SessionManager-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,38 @@ describe(SessionManager, () => {
await sessionManager.logoutAsync();
expect(sessionManager['getSessionSecret']()).toBe(null);
});

it('calls the server logout endpoint when session secret exists', async () => {
jest.mocked(fetchSessionSecretAndUserAsync).mockResolvedValue({
sessionSecret: 'SESSION_SECRET',
id: 'USER_ID',
username: 'USERNAME',
});
const apiV2PostSpy = jest.spyOn(ApiV2Client.prototype, 'postAsync');

const sessionManager = new SessionManager(analytics);
await sessionManager['loginAsync']({ username: 'USERNAME', password: 'PASSWORD' });
await sessionManager.logoutAsync();

expect(apiV2PostSpy).toHaveBeenCalledWith('auth/logout', { body: {} });
});

it('clears the local session even if the server logout call fails', async () => {
jest.mocked(fetchSessionSecretAndUserAsync).mockResolvedValue({
sessionSecret: 'SESSION_SECRET',
id: 'USER_ID',
username: 'USERNAME',
});
jest
.spyOn(ApiV2Client.prototype, 'postAsync')
.mockRejectedValueOnce(new Error('Network error'));

const sessionManager = new SessionManager(analytics);
await sessionManager['loginAsync']({ username: 'USERNAME', password: 'PASSWORD' });
await sessionManager.logoutAsync();

expect(sessionManager['getSessionSecret']()).toBe(null);
});
});

describe('showLoginPromptAsync', () => {
Expand Down
Loading