Open
Conversation
|
Subscribed to pull request
Generated by CodeMention |
byronkarlen
force-pushed
the
byron/logout-with-www
branch
from
ed9bb82 to
3bde8bb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3555 +/- ##
==========================================
- Coverage 53.85% 53.80% -0.04%
==========================================
Files 819 820 +1
Lines 34889 34984 +95
Branches 7268 7218 -50
==========================================
+ Hits 18786 18821 +35
- Misses 16012 16072 +60
Partials 91 91 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ide
requested changes
Mar 28, 2026
| try { | ||
| await apiV2Client.postAsync('auth/logout', { body: {} }); | ||
| } catch { | ||
| // Best-effort: clear the local session even if the server request fails |
Member
There was a problem hiding this comment.
Would be good to print the error to the debug log. This way most users don't see it but we also don't suppress the error when debugging.
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
ide
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Instead of waiting for sessions to expire server-side, logout should immediately invalidate the session. Users often have too many sessions at once, most of them unused.
Sessions used to be shared with the website, but are now separate with internal OAuth flow (#3542), so logging out from CLI won't affect website session. This would affect existing cli sessions though.
How
Hit /v2/auth/logout endpoint on
eas logout. If it fails, just remove credential locally (existing behavior) and credential will soon expire.Test Plan
Verified logout API call deleted session server-side. Website session remained. Also ran added unit tests.