Weather: Add v2 weather parsing in Weather App (forecast support) #3910
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
The forecast data are parsed only when requested by
weather.getWeather(true)
to minimize processing time used.PS: I haven't tested it on BangleJS 1 and I haven't tested how it behaves with older version of GadgetBridge, but I don't see reason why it should break.
PSS: I wanted to add the support for forecast parsing/api separately, as I don't know how long it will take me to make the App to show the forecast data (mostly figuring out the design of it as there is not much screen space). However, with this change, someone else can make their own in the meantime or use the data for other purpose.