-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Weather] Add feels-like temperature display #3912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Modified the shortcut to show feels like temp, based on @stweedo 's shortcut from their previous PR
I just checked your version of the shortcut and it was missing the “mostly cloudy” filter that shows multiple clouds on the bangle. I added your changes as well and this version contains everything. https://www.icloud.com/shortcuts/71f49664b5a44b6cb80703b73af2d8f0 |
Alright @stweedo thanks! |
Originally posted by @Rengyr in #3908 (comment) @RKBoss6 I think we should not merge something that adds an non functional field for android users. What do you think we tweak the logic so it only shows for ios users for now? |
There might be support for "feels like temp" for android users later (and if users will use the new GadgetBridge extended weather data, which is optional setting). So best would be to limit not it based on the platform, but just check if the field exists in the weather data we get. Either we will have value or the field will be undefined, in which case we could just hide it? |
@Rengyr I agree. We should hide the field when not in use, or no data is available. |
Before merging this, a bug needs to be fix where the icon does not fully clear itself. To achieve proper clearing, do we use g.clearRect? |
Since it uses the layout module it feels like there should be some way native to that for clearing correctly. If not maybe it should be added. I'm unfortunately not good at that module. I should learn it though... But I'll pass the question along to @bobrippling, do you know? |
{type: "txt", font: "6x8", pad: 2, valign: -1, id: "windUnit", label: "km/h"}, | ||
]}, | ||
{type: "custom", fillx: 1, height: 15, id: "uvDisplay", | ||
render: l => weather.drawIcon(l, l.x+l.w/2, l.y+l.h/2.1, l.w/2.1-10)}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is the icon that's not clearing? The custom
layout will clear it for you if you set bgCol
, then so long as you draw in the bounds I'd expect you to be alright
I did not bump the version on this commit because there are already three other PRs for weather, and I am not certain what version the app will be after all of those.