feat(jobs): add wait_for_job tool for background jobs#390
Merged
esengine merged 1 commit intoesengine:mainfrom May 7, 2026
Merged
feat(jobs): add wait_for_job tool for background jobs#390esengine merged 1 commit intoesengine:mainfrom
esengine merged 1 commit intoesengine:mainfrom
Conversation
esengine
approved these changes
May 7, 2026
Owner
esengine
left a comment
There was a problem hiding this comment.
Companion PR matches the maintainer guidance shape — wait_for_job is the single tool that replaces N polling iterations, riding the existing job registry's exit + output events. Nice touch returning the latest-output delta rather than the full buffer. Thanks for the clean follow-up.
esengine
added a commit
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
pm exec vitest run tests/jobs.test.ts tests/shell-tools.test.ts
pm run typecheck (fails on current upstream Ink/type drift in src/cli/commands/chat.tsx, src/cli/ui/layout/CardStream.tsx, and src/cli/ui/ticker.tsx, unchanged here)
Notes
waitaction/tool for intentional polling without tripping the repeat-loop guard #350.