Skip to content

fix(distillation): publish consistent Naphtali-Sandholm state - #3701

Open
EvenSol wants to merge 2 commits into
masterfrom
fix/3698-naphtali-published-state
Open

fix(distillation): publish consistent Naphtali-Sandholm state#3701
EvenSol wants to merge 2 commits into
masterfrom
fix/3698-naphtali-published-state

Conversation

@EvenSol

@EvenSol EvenSol commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator

Synchronize accepted tray inlets and terminal duties, preserve stream identity, and qualify energy diagnostics against the final public material state.

Add balance, warm-state, fail-closed, and sequential-reference regressions.

Refs #3698

AI-assisted implementation and validation.

Pull Request

Thank you for contributing to NeqSim! Please complete the following checklist before requesting review:

  • Confirm ./mvnw test runs successfully
  • Verify code formatting using Checkstyle
  • Update any relevant docs/README
  • Link to an associated issue or discussion
  • Request the applicable CODEOWNERS and record independent domain review where required
  • Add an accepted NRC and migration note if this changes a major public contract

See CONTRIBUTING.md, GOVERNANCE.md, and
the API lifecycle policy for the full contribution process.

Synchronize accepted tray inlets and terminal duties, preserve stream identity,
and qualify energy diagnostics against the final public material state.

Add balance, warm-state, fail-closed, and sequential-reference regressions.

Refs #3698

AI-assisted implementation and validation.

EvenSol commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator Author

Exact-head repair and qualification evidence

Head: 99f479b981ef7dad8d0db14d313ac7b1947b89f4

  • Previous head 11ee742bc22be3579a04b5cf4c78f531cbfbe2a2 failed two branch-attributable slow tests because sequential solvers evaluated reconciled product streams against stale terminal duties.
  • The one permitted repair updates only DistillationColumn.finalizeSolve to refresh calculated reboiler and condenser duties before evaluating the published-state energy balance. Solver algorithms, tolerances, public APIs, and frozen feature scope are unchanged.
  • The repair clears ColumnSpecificationTest.multicomponentProductFlowSpecificationHonorsMassUnit; slow shard 2 passes.
  • Slow shard 1 still fails deterministically at DistillationColumnTest.adaptiveSolverRecordsSolveMetrics:471: getLastEnergyResidual() remains non-finite for the compact metrics column.
  • Java 8 and Java 21 fast tests on Ubuntu and Windows, slow shards 2–4, Javadocs, agent checks, benchmark, documentation, formatting, PaperLab, CodeQL, and pre-commit pass.
  • Frozen nine-file scope remains intact with no Huldra overlap.
  • Open, non-draft, and mergeable with no reviews or unresolved threads.
  • The repair allowance is consumed; no second source mutation or rerun was performed.

Autonomous portfolio occupancy is 5/10, below the ten-capability ceiling.

No new PR, merge, rebase, master synchronization, Huldra change, or scope expansion was performed.

VALIDATION BLOCKED — NON-FINITE PUBLISHED ENERGY METRIC REMAINS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant