[AI-Assisted] feat(refinery): add Sarir pump-around screening - #3708
Conversation
Attributable Java fixture correctionExact head The test-only fixture now exercises the published bottom pump-around on explicit bottom-up indices 12 → 15 at the same 0.005 draw fraction. No production, documentation, source evidence, or acceptance logic changed. Test blob: Prior evidence retained: Javadocs, Spotless, pre-commit, documentation, production-documentation, CodeQL, PaperLab, agent checks, benchmark, and all four slow shards passed before the fixture correction. Full exact-head requalification is now pending. |
|
Validation correction published at exact head Both illustrative source-row mappings tried in exact-head Java CI had zero liquid draw. The strict gate rejected them as designed. No arbitrary third mapping was introduced and production code was not weakened. The regression now expects this fail-closed result; documentation explicitly states that no Sarir tray mapping is qualified. Final exact-head CI is pending. |
|
All exact-head CI passed at The PR was merged externally on 14 September 2026 at 05:09 Oslo time with merge commit The broader refinery roadmap #3305 remains open; this bounded pump-around screening increment does not complete the campaign. MERGED EXTERNALLY — EXACT-HEAD QUALIFICATION COMPLETE. |
Summary
Capability contract
Campaign: #3305
Frozen base:
dedba8735d030c6411e09b6fd7e69f6c4a136114Current exact head:
061329583b3ae412990e0fd74e720deedbdb69e8The source reports raw tray numbers but does not identify a top- or bottom-counting basis. This PR therefore does not infer or publish a qualified source-to-NeqSim mapping. Published circulation rates are comparison evidence, not solver controls or acceptance thresholds.
Engineering acceptance
Provenance
Hamza E. Omran Almansouri, Simulation of Sarir Crude Oil Refinery Using Aspen HYSYS, Journal of Engineering Research (Libya), issue 33, pages 51–64, 31 March 2022, DOI 10.66411/jer.v33i.46, CC BY 4.0.
Scope and overlap
No changes to shared column-solver internals, steam injection, side strippers, tray efficiency, blending, conversion, or plant-performance claims. Owned paths are disjoint from all open PRs, including #3701.
Review policy
Draft only. This adds public Java/JPype API and requires subsystem-owner plus independent-maintainer review before READY TO MERGE.
Validation
The sole hosted Spotless repair was generated for prior head
311e1c1302b8975e4618153b990fadb441b8cec4(artifact digestsha256:c813e123dd2d9699f8da538561b263ebfc93239a2954454c312131750220910e) and changed formatting only.Exact-head Java runs on two successive pre-correction fixtures independently showed zero liquid draw for illustrative top
30→32and bottom12→15mappings. The strict positive-flow gate rejected both as designed. No third tray mapping was guessed and the production acceptance contract was not weakened. The test and guide now qualify this fail-closed outcome and state that no Sarir mapping is published.At exact head
061329583b3ae412990e0fd74e720deedbdb69e8, Java 8 and Java 21 pass on Ubuntu and Windows, all four Java 21 slow-test shards pass, and Javadocs, Spotless, pre-commit, documentation contracts/search, production-optimization documentation, CodeQL, PaperLab, agent cross-reference, and benchmark gates pass. Currentmasteris four commits ahead of the frozen base with no overlap in the four owned files.VALIDATION COMPLETE — HUMAN REVIEW REQUIRED. No reviews or unresolved review threads are present.