Skip to content

[AI-Assisted] feat(refinery): add Sarir pump-around screening - #3708

Merged
EvenSol merged 10 commits into
masterfrom
ai/refinery-sarir-pumparound-screen
Sep 14, 2026
Merged

[AI-Assisted] feat(refinery): add Sarir pump-around screening#3708
EvenSol merged 10 commits into
masterfrom
ai/refinery-sarir-pumparound-screen

Conversation

@EvenSol

@EvenSol EvenSol commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add an explicit-mapping Sarir atmospheric pump-around screen on the qualified refinery workflow
  • preserve source tray labels separately because Table 4 does not state its numbering direction
  • derive only the published draw-minus-return cooling drops; keep caller-selected bottom-up tray indices and liquid draw fractions explicit
  • return fail-closed immutable product, convergence, flow, temperature, and duty evidence
  • document provenance, limitations, Java/JPype use, and non-calibration boundaries

Capability contract

Campaign: #3305
Frozen base: dedba8735d030c6411e09b6fd7e69f6c4a136114
Current exact head: 061329583b3ae412990e0fd74e720deedbdb69e8

The source reports raw tray numbers but does not identify a top- or bottom-counting basis. This PR therefore does not infer or publish a qualified source-to-NeqSim mapping. Published circulation rates are comparison evidence, not solver controls or acceptance thresholds.

Engineering acceptance

  • explicit, unique, valid source-row-to-NeqSim mappings
  • published temperature-drop boundary
  • caller-supplied draw fraction
  • qualified non-fallback MESH-residual Sarir products
  • converged combined column tear
  • finite positive draw/return flow with internal closure
  • finite modeled temperatures and negative cooling duty
  • immutable comparison evidence and diagnostics

Provenance

Hamza E. Omran Almansouri, Simulation of Sarir Crude Oil Refinery Using Aspen HYSYS, Journal of Engineering Research (Libya), issue 33, pages 51–64, 31 March 2022, DOI 10.66411/jer.v33i.46, CC BY 4.0.

Scope and overlap

No changes to shared column-solver internals, steam injection, side strippers, tray efficiency, blending, conversion, or plant-performance claims. Owned paths are disjoint from all open PRs, including #3701.

Review policy

Draft only. This adds public Java/JPype API and requires subsystem-owner plus independent-maintainer review before READY TO MERGE.

Validation

The sole hosted Spotless repair was generated for prior head 311e1c1302b8975e4618153b990fadb441b8cec4 (artifact digest sha256:c813e123dd2d9699f8da538561b263ebfc93239a2954454c312131750220910e) and changed formatting only.

Exact-head Java runs on two successive pre-correction fixtures independently showed zero liquid draw for illustrative top 30→32 and bottom 12→15 mappings. The strict positive-flow gate rejected both as designed. No third tray mapping was guessed and the production acceptance contract was not weakened. The test and guide now qualify this fail-closed outcome and state that no Sarir mapping is published.

At exact head 061329583b3ae412990e0fd74e720deedbdb69e8, Java 8 and Java 21 pass on Ubuntu and Windows, all four Java 21 slow-test shards pass, and Javadocs, Spotless, pre-commit, documentation contracts/search, production-optimization documentation, CodeQL, PaperLab, agent cross-reference, and benchmark gates pass. Current master is four commits ahead of the frozen base with no overlap in the four owned files.

VALIDATION COMPLETE — HUMAN REVIEW REQUIRED. No reviews or unresolved review threads are present.

EvenSol commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator Author

Attributable Java fixture correction

Exact head 5e9d7d8e0f24b713a0b2f929c70e98372f359be9 compiled and completed 14,076 Java 21 Ubuntu tests with one new-test error: the illustrative top mapping used draw tray 30, which had zero liquid traffic. The production fail-closed check behaved correctly.

The test-only fixture now exercises the published bottom pump-around on explicit bottom-up indices 12 → 15 at the same 0.005 draw fraction. No production, documentation, source evidence, or acceptance logic changed.

Test blob: 6be805ff4f64ea3446f05b98ec12710b81c33c5f5c4770567e2b5af01dfc9673ebeee4d6e22e9326
New exact head: c99c445553ec985c2175c745e1915cd4d9958280

Prior evidence retained: Javadocs, Spotless, pre-commit, documentation, production-documentation, CodeQL, PaperLab, agent checks, benchmark, and all four slow shards passed before the fixture correction. Full exact-head requalification is now pending.

EvenSol commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator Author

Validation correction published at exact head 061329583b3ae412990e0fd74e720deedbdb69e8.

Both illustrative source-row mappings tried in exact-head Java CI had zero liquid draw. The strict gate rejected them as designed. No arbitrary third mapping was introduced and production code was not weakened. The regression now expects this fail-closed result; documentation explicitly states that no Sarir tray mapping is qualified. Final exact-head CI is pending.

EvenSol commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator Author

All exact-head CI passed at 061329583b3ae412990e0fd74e720deedbdb69e8: Java 8/21 on Ubuntu and Windows, four slow shards, Javadocs, formatting, documentation, CodeQL, PaperLab, production-optimization documentation, and agent gates.

The PR was merged externally on 14 September 2026 at 05:09 Oslo time with merge commit 0787ca48c90eab461a5087321f2501b45159b502. Frozen four-file scope remained intact with no Huldra overlap. No human reviews or unresolved threads were recorded.

The broader refinery roadmap #3305 remains open; this bounded pump-around screening increment does not complete the campaign.

MERGED EXTERNALLY — EXACT-HEAD QUALIFICATION COMPLETE.

@EvenSol
EvenSol marked this pull request as ready for review September 14, 2026 03:09
@EvenSol
EvenSol merged commit 0787ca4 into master Sep 14, 2026
29 checks passed
@EvenSol
EvenSol deleted the ai/refinery-sarir-pumparound-screen branch September 14, 2026 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant