xds: add singleton subscription xDS-TP-based config-sources support #39943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adi Suissa-Peleg <[email protected]>
Signed-off-by: Adi Suissa-Peleg <[email protected]>
Signed-off-by: Adi Suissa-Peleg <[email protected]>
|
/assign @nezdolik @tonya11en @yanavlasov |
nezdolik
reviewed
Jun 23, 2025
Signed-off-by: Adi Suissa-Peleg <[email protected]>
|
Thanks for the review @nezdolik ! |
…cribe_singleton_v2 Signed-off-by: Adi Suissa-Peleg <[email protected]>
|
LGTM. Waiting for LGTM from @nezdolik as well. /wait-any |
nezdolik
approved these changes
Jun 23, 2025
|
/retest |
…cribe_singleton_v2 Signed-off-by: Adi Suissa-Peleg <[email protected]>
…cribe_singleton_v2 Signed-off-by: Adi Suissa-Peleg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: xds: add singleton subscription xDS-TP-based config-sources support
Additional Description:
Followup to #39781, as part of #24773.
This PR adds the framework for singleton subscriptions to resources that are defined using the xDS-TP config-sources in the bootstrap.
Next is to convert the current xDS singletons (EDS, RDS, etc.) to use this functionality.
Risk Level: low - not used
Testing: Added unit tests.
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
Part of #24773.