Normalize KeySequence support for testing textboxes#1181
Merged
Conversation
kitchoi
commented
Sep 2, 2020
Comment on lines
+131
to
+132
| for key in interaction.sequence: | ||
| check_key_compat(key) |
Contributor
Author
There was a problem hiding this comment.
For future reference, if we did not check and try to use QTest with a character e.g. "ಶ", then Qt will throw this error:
ASSERT: "false" in file /Users/builder/workspace/Buildsystem/test/pisi/tmp/Qt-5.12.6-5/work/qt/qtbase/src/testlib/qasciikey.cpp, line 228
Abort trap: 6
If there are needs to support a wider range of characters, then we would need to do something else. Depending on the use case, we may manually edit the text and fire the appropriate Qt event used by the editor.
Contributor
Author
There was a problem hiding this comment.
The test test_key_sequence_unsupported_key demonstrates the above error if the check was not added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
KeySequenceaccepts special keys such as "\b", "\t" for Qt. Under the hood, Qt converts these characters to Qt Key so the support is relatively painless. Similar support for wx.TextCtrl requires a bit more custom work. (See thread starting from #1171 (comment)).On the other hand, wx.TextCtrl supports some other unicode code points that QTest does not support out-of-the-box (e.g.
'\x1f'==chr(31)).For testing textboxes, it is probably not necessary to support all possible keys. It may be easier to start with a more limited support and expand it when needs arise.
This PR
- KeySequence("\b") would not be supported for textboxes. KeyClick("Backspace") should be used instead.