fix UITester wx - explicitly handle a KeyClick('Backspace') and update key_click_text_ctrl#1184
Merged
aaronayres35 merged 12 commits intomasterfrom Sep 3, 2020
Merged
Conversation
…working on windows so it is unused for now
kitchoi
reviewed
Sep 3, 2020
kitchoi
reviewed
Sep 3, 2020
kitchoi
approved these changes
Sep 3, 2020
Contributor
Author
Damn, there was one test failure on windows: Will try to fix this now before merging |
kitchoi
approved these changes
Sep 3, 2020
Contributor
kitchoi
left a comment
There was a problem hiding this comment.
Still LGTM.
Last but not least...new flake8 errors
$ flake8 traitsui/tests/editors/test_range_editor.py
traitsui/tests/editors/test_range_editor.py:16:1: E302 expected 2 blank lines, found 1
traitsui/tests/editors/test_range_editor.py:70:47: E225 missing whitespace around operator
traitsui/tests/editors/test_range_editor.py:73:71: W291 trailing whitespace
traitsui/tests/editors/test_range_editor.py:124:52: W291 trailing whitespace
traitsui/tests/editors/test_range_editor.py:128:1: W391 blank line at end of file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1183
fixes #1182
fixes #1177
This PR explicitly handles the case when a KeyClick command is issued with "Backspace" as the key. It also makes the same change that was added in PR #1181 for
key_sequence_text_ctrltokey_click_text_ctrlFinally, it makes the default behavior for entering a textbox to have the insertion point be the rightmost rather than the leftmost point of text. (this keeps consistent behavior with qt)