-
Notifications
You must be signed in to change notification settings - Fork 4
Fix EPERM and socket mismatch between selected and succeeded pairs when using bridge (Docker) interfaces. #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The problem with the test
|
Potential fixes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally, I would give an approve but this time we MUST be very verbose in comments both in the main logic as well as in tests. We spent a lot of time trying to find out what's going on with eperm and how to solve it so it MUST be very well described in comments for future reference. Especially, if it turns out that we are wrong
Nice catch!! Let's move this to a separate PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #84 +/- ##
==========================================
+ Coverage 83.88% 85.91% +2.02%
==========================================
Files 25 25
Lines 1837 1874 +37
==========================================
+ Hits 1541 1610 +69
+ Misses 296 264 -32
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…en using bridge (Docker) interfaces. (#84)
Closes #77 #83