Don't close candidate on eperm #85
Conversation
|
The problem with tests seems to be caused by ICEAgent trying to always send a binding request on the same pair, even though it always gets eperm response from the socket. |
Karolk99
force-pushed
the
82/dont-close-on-eperm
branch
from
6a072cf to
3a81786
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #85 +/- ##
==========================================
+ Coverage 83.88% 85.43% +1.55%
==========================================
Files 25 25
Lines 1837 1868 +31
==========================================
+ Hits 1541 1596 +55
+ Misses 296 272 -24
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
lib/ex_ice/priv/ice_agent.ex
Outdated
| @@ -3013,7 +3013,8 @@ defmodule ExICE.Priv.ICEAgent do | |||
| pair = %CandidatePair{ | |||
| pair | |||
| | packets_discarded_on_send: pair.packets_discarded_on_send + 1, | |||
| bytes_discarded_on_send: pair.bytes_discarded_on_send + byte_size(raw_req) | |||
| bytes_discarded_on_send: pair.bytes_discarded_on_send + byte_size(raw_req), | |||
| state: :failed | |||
There was a problem hiding this comment.
We need to do this everytime we mark a pair as failed. Can we also add a test for nomination failure?
| state: :failed | |
| state: :failed, | |
| valid?: false |
Closes #82 and also fixes the race condition described in PR 84