Fix compilation on Linux #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
After these changes, I was able to run the program on Linux (Kubuntu 22.04), without any apparent problems.
I didn't test compilation on windows (I don't have a version that is set up), but it shouldn't cause many errors.
I translated the debug and release build scripts with gpt, it's basically the same as the windows one.
ImGuiUi.cpp:
The chosen folder was appended with a
\, which caused the file to not export. I looked and it looks like destinationFilePathFolder is not used anywhere else, other than at getMeshFullFilePathDestination, but a/is appended after the file path there anyway, so my guess would be that the\may not be needed on windows either.utils.cpp/hpp:
crtdbg.h looks like is not used, and is not available here so I deleted the include
getExecutablePath+getExecutableDir uses windows specific code, but it is not used anywhere so I deleted these 2
afterwards windows.h was not needed either, only math.h for isnan
I also added a chapter into the readme for linux compilation.
And I also filled out the CLA.