Skip to content

Test Copilot Coding Agent environment with terraform-provider-elasticstack acceptance tests and update copilot instructions #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Test Copilot Coding Agent environment with terraform-provider-elasticstack acceptance tests and update copilot instructions #1282

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ff2aaf
Initial plan
Copilot Sep 5, 2025
38365e0
Add acceptance testing requirements to copilot instructions
Copilot Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/copilot-instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,19 @@ Carefully read the issue and think hard about a plan to solve it before coding.
- Write additional tests if needed to capture important behaviors or edge cases.
- Ensure all tests pass before finalizing.

### 6.1 Acceptance Testing Requirements
When running acceptance tests (`make testacc`), ensure the following:

- **Always use `make testacc`** - This target automatically sets `TF_ACC=1` which is required for acceptance tests to run
- **Environment Variables** - The following environment variables are required for acceptance tests:
- `ELASTICSEARCH_ENDPOINTS` (default: http://localhost:9200)
- `ELASTICSEARCH_USERNAME` (default: elastic)
- `ELASTICSEARCH_PASSWORD` (default: password)
- `KIBANA_ENDPOINT` (default: http://localhost:5601)
- **Pre-set Environment Variables** - Default environment variables are configured in the Makefile. If these defaults are suitable for your testing environment, `make testacc` will work directly without additional setup
- **Docker Environment** - For isolated testing with guaranteed environment setup, use `make docker-testacc` which starts Elasticsearch and Kibana containers automatically
- **Never run acceptance tests manually** with `go test` unless you explicitly set `TF_ACC=1` and all required environment variables

## 7. Final Verification
- Confirm the root cause is fixed.
- Review your solution for logic correctness and robustness.
Expand Down