Test Copilot Coding Agent environment with terraform-provider-elasticstack acceptance tests and update copilot instructions

[Copilot]

This PR demonstrates and verifies that the Copilot Coding Agent environment is fully capable of running acceptance tests for the terraform-provider-elasticstack repository, and updates the copilot instructions to ensure proper acceptance test execution.

What was tested

• Direct make testacc execution with updated default environment variables
• Acceptance tests with proper environment (Elasticsearch and Kibana containers)
• Specific acceptance test validation:
  • TestAccResourceSecuritySystemUser - All variants passed (5.07s)
  • TestAccResourceSecurityApiKey - All 6 test cases passed (14.94s)
  • TestProvider - Core provider functionality validated
• Unit tests - Complete suite runs successfully (168 tests across 30+ packages)

Environment verification

The testing environment provides:

• Go 1.25.0 - Compatible with the repository requirements
• Docker 28.0.4 - Capable of running Elasticsearch/Kibana containers
• Network access - Services can communicate on localhost
• Container management - Full lifecycle management of test dependencies

Updated default environment variables confirmed working

The default environment variables have been updated and are working correctly:

• ELASTICSEARCH_ENDPOINTS=http://localhost:9200
• ELASTICSEARCH_USERNAME=elastic
• ELASTICSEARCH_PASSWORD=password
• KIBANA_ENDPOINT=http://localhost:5601

This allows make testacc to work directly without manual environment setup, as confirmed by successful test execution.

Updated copilot instructions

• Added Section 6.1 Acceptance Testing Requirements - Comprehensive guidance for running acceptance tests correctly
• TF_ACC=1 requirement - Documents that make testacc automatically sets this required environment variable
• Environment variable documentation - Lists required variables with their default values from Makefile
• Pre-set environment usage - Emphasizes using Makefile defaults for seamless test execution
• Docker-based testing - Adds guidance for make docker-testacc for isolated testing environments
• Manual testing warnings - Prevents incorrect manual go test execution without proper setup

Testing infrastructure confirmed

The repository's testing infrastructure is robust and well-designed:

• Clear separation between unit tests and acceptance tests
• Proper environment variable validation in internal/acctest/acctest.go
• Docker-based service management via Makefile targets
• Support for both focused test execution and full test suites
• Comprehensive test coverage across provider functionality

This verification confirms that the Copilot Coding Agent environment can effectively run the acceptance test suite for development and validation workflows, with updated instructions ensuring proper test execution procedures.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[cla-checker-service]

❌ Author of the following commits did not sign a Contributor Agreement:
9ff2aaf, 38365e0

Please, read and sign the above mentioned agreement if you want to contribute to this project

[tobio]

@copilot I've updated the default environment variables so make testacc should work directly. Try running the tests again.

[Copilot]

@copilot I've updated the default environment variables so make testacc should work directly. Try running the tests again.

Confirmed! The acceptance tests are now working directly with make testacc. I successfully ran several acceptance tests including:

• TestAccResourceSecuritySystemUser - All variants passed (5.07s)
• TestAccResourceSecurityApiKey - All 6 test cases passed (14.94s)
• TestProvider - Core provider functionality validated

The default environment variables are properly configured:

• ELASTICSEARCH_ENDPOINTS=http://localhost:9200
• ELASTICSEARCH_USERNAME=elastic
• ELASTICSEARCH_PASSWORD=password
• KIBANA_ENDPOINT=http://localhost:5601

Unit tests are also running successfully (168 tests across 30+ packages), confirming the testing environment is fully operational for both acceptance and unit testing workflows.

[tobio]

@copilot can you propose a change to the copilot instructions that would ensure acceptance tests are run correctly as required. Making sure:

• Pre-set environment variables are used if available
• TF_ACC=1 is set when any acceptance test runs are attempted

[Copilot]

@copilot can you propose a change to the copilot instructions that would ensure acceptance tests are run correctly as required. Making sure:

• Pre-set environment variables are used if available
• T...

I've updated the copilot instructions to ensure acceptance tests are run correctly. The changes include:

• Section 6.1 Acceptance Testing Requirements - Added detailed guidance covering:
  • Always use make testacc which automatically sets TF_ACC=1
  • Required environment variables with defaults (ELASTICSEARCH_ENDPOINTS, ELASTICSEARCH_USERNAME, etc.)
  • Using pre-set environment variables from Makefile for direct execution
  • Docker-based testing option with make docker-testacc
  • Warning against manual go test execution without proper setup

The updated instructions ensure that:

1. Pre-set environment variables are properly utilized (defaults in Makefile allow make testacc to work directly)
2. TF_ACC=1 is always set when running acceptance tests (via the make testacc target)

Commit: 38365e0