-
Notifications
You must be signed in to change notification settings - Fork 27
Reduce CPU consumption and heap allocations of SubsystemMountpoints() #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
rockdaboot
wants to merge
11
commits into
main
Choose a base branch
from
rockdaboot/optimize-subsystemmountpoints
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c447378
to
a457e27
Compare
kruskall
added a commit
that referenced
this pull request
Jun 16, 2025
## What does this PR do? Update golangci-lint to 1.64.8, the latest version before v2, which requires fundamental changes to the config file (for a follow-up PR). <!-- Mandatory Explain here the changes you made on the PR. Please explain the WHAT: patterns used, algorithms implemented, design architecture, message processing, etc. --> ## Why is it important? PR #220 requires a newer version of the linter in order to allow Go 1.23 iterators. ## Checklist - [x] My code follows the style guidelines of this project - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added tests that prove my fix is effective or that my feature works --------- Co-authored-by: kruskall <[email protected]>
ed982b4
to
f217e0f
Compare
65d8294
to
f470f43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR reduces memory allocations and thus GC activity in a hot path (
SubsystemMountpoints()
).It also adds a benchmark that can be run with
Benchmark results Before
Benchmark results After
It became aware when looking at the Universal Profiling flamegraph for
auditbeat
thatSubsystemMountpoints()
was consuming ~25% of the CPU usage ofauditbeat
. Additionally, it created a lot of unneeded heap allocations for temporary (function-local) variables. The GC ate another ~21% of the total CPU consumption ofauditbeat
.Screenshot (data from a real set of >200 Elasticsearch clusters)
Why is it important?
As long running applications, the beats should consume as less CPU as possible.
Checklist