Update linter to 1.64.8 #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockdaboot
requested review from
AndersonQ,
VihasMakwana and
kruskall
and removed request for
a team
AndersonQ
reviewed
Jun 4, 2025
kruskall
reviewed
Jun 4, 2025
pierrehilbert
added
the
Team:Elastic-Agent-Data-Plane
AndersonQ
previously approved these changes
Jun 4, 2025
|
Looks good, just the failing test to fix |
|
those tests are also failing in other PRs: https://github.com/elastic/elastic-agent-system-metrics/pulls they seem unrelated to the changes :( |
kruskall
previously approved these changes
Jun 5, 2025
AndersonQ
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update golangci-lint to 1.64.8, the latest version before v2, which requires fundamental changes to the config file (for a follow-up PR).
Why is it important?
PR #220 requires a newer version of the linter in order to allow Go 1.23 iterators.
Checklist